chore: opt card - #54
Merged
Merged
Conversation
The card's heading was split on the comma so the country could carry the lighter ink. That put the comma on the city's side of the split and in the city's weight, so the line read "Shanghai," and then "China" rather than reading "Shanghai, China" — the two tones separated a name that is one thing. The heading is now `.label` whole, semibold, one colour: the weight is what separates the place from the handles under it, which is the only distinction that line needs. Country-level marks like India stop being a special case. Verified over CDP at 1440, 390 and 320: no heading wraps except "Amsterdam, Netherlands" in the 131px card the narrowest screen gives it, and the pointer walk from a dot into a card's links is unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The card was 13rem wide whatever it held, in 14px type with 24px faces 3px
apart. At its most common — one handle — that was "cr7258" alone in a 187px box,
and the column of faces read as circles touching rather than as a list.
- Width is `max-content` between 10rem and 13rem, both bounds still capped by
`--map-room` so nothing crosses the map's edge on a narrow screen. The floor
is what keeps shrink-to-fit from making a 95px stub of a card; the ceiling is
what stops a long handle from taking the old width back. In practice the
cards are one width, 144px, and only a handle longer than any on the map
today would widen one.
- 13px type rather than 14px, 20px faces rather than 24px, and 4px of air
around each row rather than 3px: a face and its handle are now the same size
of thing, which is what a row of a list is.
- The place name loses its semibold. The rule under it already separates it
from the list, so the weight was a second way of saying the same thing, and
it made the name the loudest thing in a panel that exists to show the people.
Verified over CDP at 320, 390 and 1440: all 23 cards open, all 34 avatars load,
no card crosses a viewport edge, the page has no horizontal scrollbar at 320,
targets still sit on their dots to within 0.06px, and the pointer walk from a
dot into a card's links still holds the card open. No heading wraps except
"Amsterdam, Netherlands" in the 131px card the narrowest screen allows it.
Paris still cannot be opened by pointing at its own dot — one of the five
overlapping marks noted in d2a7082, unchanged here and reachable by keyboard.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
@kerthcet is attempting to deploy a commit to the InftyAI Team on Vercel. A member of the Team first needs to authorize it. |
Member
Author
|
/lgtm |
InftyAI-Agent
added
needs-triage
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
InftyAI-Agent
added
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.