-
Notifications
You must be signed in to change notification settings - Fork 66
feat(gateway): load balancing #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bernie-g
wants to merge
7
commits into
main
Choose a base branch
from
bernie/pam-375-gateway-load-reporting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
90e25b4
feat(gateway): report active channel count for pool load balancing
bernie-g 6210b36
fix(gateway): bound the load report request
bernie-g 1d66d56
refactor(gateway): rename the load report endpoint to /metrics
bernie-g f5b073a
chore(deps): bump pion/stun to v3.1.5
bernie-g 5e9ed35
chore(deps): sync the e2e module with the stun bump
bernie-g d9c4392
chore(gateway): trim comments and correct the reporting note
bernie-g 37c4648
fix(gateway): bound the active channel count and back off failed reports
bernie-g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| package gatewayv2 | ||
|
|
||
| import ( | ||
| "sync" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestReleaseChannelNeverGoesNegative(t *testing.T) { | ||
| g := &Gateway{} | ||
| g.activeChannels.Add(1) | ||
| g.activeChannels.Add(1) | ||
|
|
||
| // Reset with handlers still in flight, as on a relay reconnect. | ||
| g.activeChannels.Store(0) | ||
|
|
||
| var wg sync.WaitGroup | ||
| for i := 0; i < 2; i++ { | ||
| wg.Add(1) | ||
| go func() { | ||
| defer wg.Done() | ||
| g.releaseChannel() | ||
| }() | ||
| } | ||
| wg.Wait() | ||
|
|
||
| if got := g.activeChannels.Load(); got != 0 { | ||
| t.Fatalf("count went to %d, want 0", got) | ||
| } | ||
| } | ||
|
|
||
| func TestReleaseChannelDecrements(t *testing.T) { | ||
| g := &Gateway{} | ||
| g.activeChannels.Add(3) | ||
| g.releaseChannel() | ||
| if got := g.activeChannels.Load(); got != 2 { | ||
| t.Fatalf("count is %d, want 2", got) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Low: Stale handlers decrement the new connection's count
After
activeChannelsis reset during reconnect, this CAS cannot tell whether the releasing handler belongs to the old or current connection. An authenticated client can keep old handlers stalled across a reconnect and close them after new channels are counted, making those stale handlers decrement the new connection's load and attract additional traffic. Track counts per connection generation, or pass a generation-specific counter into each handler, so releases only affect the connection that acquired them.