Stop toasting when the consensus-checklist creation race is lost - #845
Merged
Merged
Conversation
The reconcile page created the consensus checklist and then immediately updated it to reconciling. When another client had already created it, the server rejected the create as DuplicateChecklist and the follow-up update as NotFound, and the pool toasted both while the page silently adopted the winner. A consensus checklist is now born reconciling with its title, so there is no follow-up update to fail, and the pool skips the toast for a consensus create lost to DuplicateChecklist since the page recovers on its own. Closes #844 Claude-Session: https://claude.ai/code/session_01TAEtViwHmBCJSDSVKkzTD6
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #844
Problem
Two reviewers opening the same reconciliation at once both create the consensus checklist. The loser's
checklist.createis rejected asDuplicateChecklist, which rolls the optimistic row back, so the unconditional follow-upchecklist.update(status reconciling, title) is rejected asNotFound. The pool toasted both. The page already adopts the winner through its race-recovery effect, so both toasts were noise and the second was wrong.Change
checklist.createwithkind: 'consensus'now creates the row already reconciling and titled "Reconciled Checklist". A consensus checklist only exists to be reconciled, so the follow-up update is gone along with theNotFoundrejection.ReconciliationWrapperno longer issues that update after the create.ConnectionPoolstill logs the rejection but skips the toast for a consensus create rejected asDuplicateChecklist. Reviewer-kind duplicates from the To-Do tab still toast.The seed and templates path already sends a
checklist.updateafter creating consensus rows, which remains valid.Verification
pnpm --filter @corates/shared test: 333 passedpnpm --filter web test(localCollections, reconcile): 324 passedpnpm typecheck,pnpm lint: cleanhttps://claude.ai/code/session_01TAEtViwHmBCJSDSVKkzTD6
Summary by CodeRabbit