feat(cambricon): add Embedding implementation - #926
Open
baominghelly wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Embeddingimplementation with a CNNL fast path for contiguous tensors and a custom BANG C path for scalar and strided tensors.max_normrenormalization and introduce reusable CNNL/CNRT resource helpers.Motivation
Enable native
Embeddingexecution on Cambricon while preserving the existing InfiniOps interface formax_normand layouts that CNNL does not accept directly.No linked issue.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
The required affected-platform smoke build and
tests -m smokeset have not been run after the latest commit. Focused Cambricon validation was run in container0f34305d9bc9oncambricon218_01:A clean Cambricon
infiniops/opsbuild and installation also completed successfully during focused validation.Test Results on Supported Platforms
tests/test_embedding.py: 60 passedFocused validation output
Benchmark / Performance Impact
N/A - this is a new backend implementation; no baseline benchmark was collected.
Notes for Reviewers
max_normrenormalization.IndexError.cnnl_utils.handcnrt_utils.hcentralize reusable CNNL descriptor/handle ownership and CNRT device-buffer ownership for future Cambricon operators.kernel.hand its implementation is inkernel.mlu, matching existing Cambricon operator practice. This differs from the literal launcher-placement wording inCONTRIBUTING.mdand should be confirmed by maintainers.masterand rerun the required affected-platform smoke build and smoke test set.