feat(cambricon): add Add operator - #921
Open
baominghelly wants to merge 1 commit into
Open
Conversation
baominghelly
force-pushed
the
feat/cambricon-add
branch
from
August 11, 2026 09:04
0c060bf to
57813b0
Compare
baominghelly
force-pushed
the
feat/cambricon-add
branch
from
August 11, 2026 09:20
57813b0 to
b6c003a
Compare
baominghelly
marked this pull request as ready for review
August 12, 2026 02:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addinsrc/native/cambricon/ops/add/, includingalpha, broadcasting, non-contiguous layouts, and contiguous fast-path execution.float16,bfloat16,float32,int32, andint64, and skip dtype combinations thattorch.mlucannot clone before backend execution.Motivation
Extend canonical
Addcoverage to Cambricon while matching the currentinput + alpha * otherinterface and preserving the defaultalpha=1overload. The implementation handles both contiguous tensors and broadcast/strided layouts used by the existing cross-platform Add test matrix.No linked issue.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Focused Cambricon Add build and full operator test in
infinicore-cambricon-dev-libaomingoncambricon218_01:The repository-wide default Cambricon smoke set was not run; validation was scoped to the affected operator.
Test Results on Supported Platforms
tests/test_add.py: 84 passed, 48 skippedFull `pytest` output
Benchmark / Performance Impact
N/A. This PR adds backend coverage and makes no performance claim.
Notes for Reviewers
DispatchFuncmaps the runtime dtype to Cambricon native types.alphais converted tofloatfor device execution; integral tensors use an integralalpha, as validated by the base operator.torch.mlucloning limitations forint16and unsigned integer dtypes before the InfiniOps kernel is invoked.clang-format 21.1.2was installed in the Cambricon container;clang-format --dry-run --Werrorpassed for the two added native files.