Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
cmake_minimum_required(VERSION 3.18)
project(InfiniCCL VERSION 0.1.0 LANGUAGES C CXX)

include(CTest)

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

Expand Down Expand Up @@ -507,6 +509,9 @@ add_subdirectory(src)
if(BUILD_EXAMPLES)
add_subdirectory(examples)
endif()
if(BUILD_TESTING)
add_subdirectory(tests)
endif()

# =========================================================
# --- Installation ---
Expand Down
17 changes: 17 additions & 0 deletions src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,21 @@ set(AUTOGEN_WARNING [[/*

file(GLOB CORE_SRCS "*.cc")
file(GLOB_RECURSE BASE_IMPL_SRCS "base/*.cc")
file(GLOB_RECURSE BRIDGE_DEP_HEADERS CONFIGURE_DEPENDS
"base/*.h"
"backends/*.h"
"devices/*.h"
"devices/*.cuh"
)

string(REPLACE ";" "\n" BRIDGE_DEPENDENCY_CONTENT "${BRIDGE_DEP_HEADERS}")
set(BRIDGE_DEPENDENCY_MANIFEST
"${CMAKE_CURRENT_BINARY_DIR}/bridge_dependencies.txt"
)
file(GENERATE
OUTPUT "${BRIDGE_DEPENDENCY_MANIFEST}"
CONTENT "${BRIDGE_DEPENDENCY_CONTENT}\n"
)

target_sources(infiniccl PRIVATE
${CORE_SRCS}
Expand Down Expand Up @@ -298,7 +313,9 @@ add_custom_command(
"${BACK_STR}"
DEPENDS "${PROJECT_SOURCE_DIR}/scripts/gen_bridge.py"
"${PROJECT_SOURCE_DIR}/include/comm.h"
"${BRIDGE_DEPENDENCY_MANIFEST}"
${BASE_IMPL_SRCS}
${BRIDGE_DEP_HEADERS}
VERBATIM
COMMENT "Generating InfiniCCL bridge and manifest files for Devices: [${DEV_STR}] Backends: [${BACK_STR}]..."
)
Expand Down
6 changes: 6 additions & 0 deletions tests/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
add_test(
NAME bridge_dependency_contract
COMMAND ${Python3_EXECUTABLE}
"${CMAKE_CURRENT_SOURCE_DIR}/bridge_dependency_contract.py"
"${PROJECT_SOURCE_DIR}/src/CMakeLists.txt"
)
44 changes: 44 additions & 0 deletions tests/bridge_dependency_contract.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
import pathlib
import re
import sys


def main():
source = pathlib.Path(sys.argv[1]).read_text(encoding="utf-8")

header_glob = re.search(
r"file\(GLOB_RECURSE BRIDGE_DEP_HEADERS CONFIGURE_DEPENDS(.*?)\n\)",
source,
re.DOTALL,
)
assert header_glob is not None
assert set(re.findall(r'"([^"]+)"', header_glob.group(1))) == {
"base/*.h",
"backends/*.h",
"devices/*.h",
"devices/*.cuh",
}

assert re.search(
r"file\(GENERATE\s+"
r'OUTPUT "\$\{BRIDGE_DEPENDENCY_MANIFEST\}"\s+'
r'CONTENT "\$\{BRIDGE_DEPENDENCY_CONTENT\}\\n"\s*'
r"\)",
source,
)

bridge_command = re.search(
r"add_custom_command\(\s+"
r'OUTPUT "\$\{GENERATED_BRIDGE\}" "\$\{GENERATED_MANIFEST\}"'
r"(.*?)\n\)",
source,
re.DOTALL,
)
assert bridge_command is not None
dependencies = bridge_command.group(1)
assert '"${BRIDGE_DEPENDENCY_MANIFEST}"' in dependencies
assert "${BRIDGE_DEP_HEADERS}" in dependencies


if __name__ == "__main__":
main()
Loading