Skip to content

fix(toast): replace iframe with Sample component#323

Open
viktorkombov wants to merge 1 commit into
masterfrom
vkombov/fix-320
Open

fix(toast): replace iframe with Sample component#323
viktorkombov wants to merge 1 commit into
masterfrom
vkombov/fix-320

Conversation

@viktorkombov

Copy link
Copy Markdown
Contributor

Closes #320

Checklist:

  • check topic's TOC/menu and paragraph headings
  • Include TOC topic labels in the topic content when it has a valuable update, is new, or is considered preview / beta
  • link to other topics using ../relative/path.md
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check if links function by running the check-api/mdx npm commands
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo


  • do not resolve requested changes (leave that to the reviewer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Angular: Empty iframe displayed in a Toast page example

2 participants