chage(cli): rename completeAndRun to complete and install and update…#1733
Open
Marina-L-Stoyanova wants to merge 1 commit into
Open
chage(cli): rename completeAndRun to complete and install and update…#1733Marina-L-Stoyanova wants to merge 1 commit into
Marina-L-Stoyanova wants to merge 1 commit into
Conversation
|
coverage: 87.771% (-0.01%) from 87.785% — mstoyanova/wizard-steps-update into master |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the step-by-step (ig wizard) completion flow by removing the “run” step, renaming the internal completion hook from completeAndRun to complete, and printing “Next Steps” guidance after installation to avoid confusion about the user’s shell working directory.
Changes:
- Replace the wizard’s “Complete & Run” action with “Complete and Install packages” and stop invoking
start. - Rename
BasePromptSession.completeAndRun()toBasePromptSession.complete()and update CLI + schematics implementations accordingly. - Add
showNextSteps()output after completion and adjust unit tests to match the new flow.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/unit/PromptSession-spec.ts | Updates wizard-flow tests to use the new completion action and assert install + “Next Steps” behavior (no start). |
| packages/ng-schematics/src/prompt/SchematicsPromptSession.ts | Renames the completion hook to complete() to match the core prompt base API. |
| packages/core/prompt/BasePromptSession.ts | Introduces _newProjectName, renames completion API, updates action choice strings, and adds showNextSteps() after completion. |
| packages/cli/lib/PromptSession.ts | Implements complete() to install and flush packages without starting the app. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+462
to
+470
| private showNextSteps() { | ||
| Util.log(""); | ||
| Util.log("Next Steps:"); | ||
| if (this._newProjectName) { | ||
| Util.log(` cd ${this._newProjectName}`); | ||
| } | ||
| Util.log(" ig add start guided mode for adding views to the app"); | ||
| Util.log(" ig start starts a web server and opens the app in the default browser"); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… related logic
Description
Removing the Run step from the Step-by-step guide and updating withe Next steps.
Related Issue
Closes #1728
Type of Change
Affected Packages
igniteui-cli(packages/cli)@igniteui/cli-core(packages/core)@igniteui/angular-templates(packages/igx-templates)@igniteui/angular-schematics(packages/ng-schematics)@igniteui/mcp-server(packages/igniteui-mcp)Checklist
npm run test)npm run build)npm run lint)Additional Context