fix(upgrade-packages): detect framework & run without ignite-ui-cli.json by Copilot · Pull Request #1690 · IgniteUI/igniteui-cli

Copilot · 2026-05-15T10:22:46Z

ig upgrade-packages throws Cannot read properties of undefined (reading 'framework') when run in a project without ignite-ui-cli.json, since config.project is undefined when no local config exists.

Changes

Auto-detect framework: When config.project.framework is absent, fall back to the existing detectFrameworkFromPackageJson() utility to infer the framework from package.json dependencies
Safe property access: Use optional chaining on config.project?.framework, config.project?.projectType, and config.project?.projectTemplate
Derive projectType: Map detected framework to its project type (angular→igx-ts, react→igr-ts, webcomponents→igc-ts) when not specified in config
Informative error: Log a clear message when neither config nor package.json can determine the framework

// Before: crashes when config.project is undefined
const framework = config.project.framework;

// After: falls back to package.json detection
let framework = config.project?.framework;
if (!framework) {
    const detected = detectFrameworkFromPackageJson();
    if (!detected) {
        Util.log("Unable to determine the project framework. ...", "yellow");
        return;
    }
    framework = detected;
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

www.google-analytics.com
- Triggering command: /usr/local/bin/node node packages/cli/bin/execute.js new --help (dns block)
- Triggering command: /usr/local/bin/node node packages/cli/bin/execute.js config --help (dns block)
- Triggering command: /usr/local/bin/node node packages/cli/bin/execute.js generate --help (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…ework from package.json Agent-Logs-Url: https://github.com/IgniteUI/igniteui-cli/sessions/836f72b0-5436-41af-a5f3-4dba187bbe1a Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>

Agent-Logs-Url: https://github.com/IgniteUI/igniteui-cli/sessions/836f72b0-5436-41af-a5f3-4dba187bbe1a Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>

coveralls · 2026-05-15T11:36:43Z

coverage: 87.455% (+0.08%) from 87.371% — copilot/fix-upgrade-packages-error into master

damyanpetev · 2026-05-19T08:49:01Z

+		if (!framework) {
+			const detected = detectFrameworkFromPackageJson();
+			if (!detected) {
+				Util.log("Unable to determine the project framework. " +


@copilot Can use Util.warn then to put this in the right standard io (can keep the explicit color) and you will need to spy that for the message test

Switched to Util.warn and updated the test to spy on it. Done in a637180.

Agent-Logs-Url: https://github.com/IgniteUI/igniteui-cli/sessions/39a81310-9882-4de1-94db-8318a994b9d0 Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>

Copilot · 2026-05-19T08:51:33Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

www.google-analytics.com
- Triggering command: /usr/local/bin/node node packages/cli/bin/execute.js new --help de_modules/.bin/tsx ma && npm run build:mcp (dns block)
- Triggering command: /usr/local/bin/node node packages/cli/bin/execute.js config --help (dns block)
- Triggering command: /usr/local/bin/node node packages/cli/bin/execute.js generate --help (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot

Pull request overview

This PR aims to prevent ig upgrade-packages from crashing when a project has no local ignite-ui-cli.json by safely reading config.project and falling back to framework detection from package.json.

Changes:

Add optional chaining for config.project access and fall back to detectFrameworkFromPackageJson() when framework is missing.
Derive a default projectType from the detected framework via a simple mapping.
Add unit tests covering the “no config” detection path and the “cannot detect framework” warning path.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
`packages/cli/lib/commands/upgrade.ts`	Adds framework/package.json fallback and derives `projectType` when config is missing.
`spec/unit/upgrade-spec.ts`	Adds unit tests for framework auto-detection and the warning when detection fails.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

 		const config = ProjectConfig.getConfig();
-		const framework = config.project.framework;
-		const projectType = config.project.projectType;
+		let framework = config.project?.framework;
+		let projectType = config.project?.projectType;
+
+		if (!framework) {
+			const detected = detectFrameworkFromPackageJson();
+			if (!detected) {
+				Util.warn("Unable to determine the project framework. " +
+					"Please ensure you are running this command in a project directory with a package.json file, " +
+					"or create an ignite-ui-cli.json configuration file.", "yellow");
+				return;


 					const projectLibrary = templateManager.getProjectLibrary(framework, projectType);
 					let project: ProjectTemplate;
-					if (!config.project.projectTemplate || !projectLibrary.hasProject(config.project.projectTemplate)) {
+					if (!config.project?.projectTemplate || !projectLibrary.hasProject(config.project.projectTemplate)) {
 						// in case project template is missing from the config we provide backward.
 						project = projectLibrary.getProject(projectLibrary.projectIds[0]);
 					} else {


+	it("Should auto-detect framework from package.json when config has no project", async () => {
+		const config = {} as Config;
+		spyOn(ProjectConfig, "getConfig").and.returnValue(config);
+		spyOn(detectFrameworkModule, "detectFrameworkFromPackageJson").and.returnValue("react");
+


damyanpetev · 2026-05-19T09:04:21Z

+	angular: "igx-ts",
+	react: "igr-ts",
+	webcomponents: "igc-ts"
+};


Might be worth to add default project type per framework (bit out of scope), even though those are currently singular IIRC and templateManager.getProjectLibrary will return the first if type is not supplied, so this can possibly even be dropped. Need to check tho.

Initial plan

cfc917f

Copilot AI assigned Copilot and kdinev May 15, 2026

Copilot started work on behalf of kdinev May 15, 2026 10:22 View session

Copilot AI linked an issue May 15, 2026 that may be closed by this pull request

ig upgrade-packages throws an error when it doesn't find any ignite-ui-cli.json #1663

Open

Copilot AI and others added 2 commits May 15, 2026 10:26

fix: handle missing config in upgrade-packages by auto-detecting fram…

bc791a0

…ework from package.json Agent-Logs-Url: https://github.com/IgniteUI/igniteui-cli/sessions/836f72b0-5436-41af-a5f3-4dba187bbe1a Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>

refactor: consolidate projectType mapping logic in upgrade command

29fe92c

Agent-Logs-Url: https://github.com/IgniteUI/igniteui-cli/sessions/836f72b0-5436-41af-a5f3-4dba187bbe1a Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix ig upgrade-packages error for ignite-ui-cli.json~~ Fix upgrade-packages crash when ignite-ui-cli.json is missing May 15, 2026

Copilot finished work on behalf of kdinev May 15, 2026 10:29

Copilot AI requested a review from kdinev May 15, 2026 10:29

kdinev added the ❌ status: awaiting-test label May 15, 2026

kdinev requested a review from damyanpetev May 19, 2026 07:36

Merge branch 'master' into copilot/fix-upgrade-packages-error

59a3e68

damyanpetev reviewed May 19, 2026

View reviewed changes

Copilot started work on behalf of damyanpetev May 19, 2026 08:49 View session

refactor: use Util.warn for framework detection warning message

a637180

Agent-Logs-Url: https://github.com/IgniteUI/igniteui-cli/sessions/39a81310-9882-4de1-94db-8318a994b9d0 Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>

Copilot finished work on behalf of damyanpetev May 19, 2026 08:51

Copilot AI requested a review from damyanpetev May 19, 2026 08:51

damyanpetev marked this pull request as ready for review May 19, 2026 08:52

Merge branch 'master' into copilot/fix-upgrade-packages-error

35aeec2

Copilot AI review requested due to automatic review settings May 19, 2026 08:52

damyanpetev added the commands label May 19, 2026

Copilot started reviewing on behalf of damyanpetev May 19, 2026 08:53 View session

damyanpetev added the enhancement label May 19, 2026

damyanpetev changed the title ~~Fix upgrade-packages crash when ignite-ui-cli.json is missing~~ fix(upgrade-packages): detect framework & run without ignite-ui-cli.json May 19, 2026

damyanpetev approved these changes May 19, 2026

View reviewed changes

damyanpetev added the squash-merge label May 19, 2026

Copilot AI reviewed May 19, 2026

View reviewed changes

damyanpetev reviewed May 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(upgrade-packages): detect framework & run without ignite-ui-cli.json#1690

fix(upgrade-packages): detect framework & run without ignite-ui-cli.json#1690
Copilot wants to merge 6 commits into
masterfrom
copilot/fix-upgrade-packages-error

Copilot AI commented May 15, 2026 •

edited

Loading

Uh oh!

coveralls commented May 15, 2026 •

edited

Loading

Uh oh!

damyanpetev May 19, 2026

Uh oh!

Copilot AI May 19, 2026

Uh oh!

Copilot AI commented May 19, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Uh oh!

damyanpetev May 19, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Copilot AI commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

coveralls commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

damyanpetev May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented May 19, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

damyanpetev May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented May 15, 2026 •

edited

Loading

coveralls commented May 15, 2026 •

edited

Loading

damyanpetev May 19, 2026 •

edited

Loading