Repository navigation
fix(drag-drop): keep the ghost under the pointer during window auto-scroll - #18026
Open
damyanpetev wants to merge 1 commit into
Open
damyanpetev wants to merge 1 commit into
damyanpetev wants to merge 1 commit into
Conversation
…croll Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #18024, which adds the
igxDrag window auto-scrolltests this extends.While
igxDragauto-scrolls the window with the pointer held still near the viewport edge, a ghost with a margin drifts away from the pointer. It moves up and left by its margin on every scroll step, so a ghost withmargin: 10pxis 50px off within a few steps. The next pointer move snaps it back.Each scroll step moves the ghost with
ghostTop += scrollByY. TheghostLeft/ghostTopsetters take a page position that includes the margin and subtract it before writingstyle.left/style.top, but the getters returned the style value without adding it back. Every read-and-write cycle lost the margin.The getters now add the margin back, so they return the position the setters take. This also changes
locationfor a ghost with a margin. It now reports the same positionsetLocation()takes, consistent withlocationwithout a ghost. Before, it was off by the margin.🤖 Generated with Claude Code