feat(chip): add outlined version - #17517
Open
adrianptrv wants to merge 4 commits into
Open
Conversation
8 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an outlined visual variant for the Chip component across themes, updates the underlying theming tokens for focus styling (breaking change), and provides a v22.2.0 migration + tests to automatically update affected theme usages.
Changes:
- Adds
outlinedAPI toIgxChipComponentand exercises it in unit tests. - Extends chip theming SCSS across shared + dark theme variants to support outlined styling and updates focus token names.
- Adds a v22.2.0 migration (
migration-59) to renamechip-themefocus token properties, plus changelog + sample updates.
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/chips/chips.sample.scss | Adjusts sample layout to include outlined chips in the grid. |
| src/app/chips/chips.sample.html | Adds outlined chip examples for Angular + Web Components samples. |
| projects/igniteui-angular/migrations/update-22_2_0/index.ts | Registers the v22.2.0 migration entry point. |
| projects/igniteui-angular/migrations/update-22_2_0/index.spec.ts | Adds a schematic test ensuring the token renames occur. |
| projects/igniteui-angular/migrations/update-22_2_0/changes/theme-changes.json | Defines the token rename rules for chip-theme. |
| projects/igniteui-angular/migrations/migration-collection.json | Registers migration-59 for v22.2.0. |
| projects/igniteui-angular/chips/src/chips/themes/shared/_indigo.scss | Updates focus token usage and adds outlined styling overrides. |
| projects/igniteui-angular/chips/src/chips/themes/shared/_fluent.scss | Adds outlined styling overrides for Fluent shared theme. |
| projects/igniteui-angular/chips/src/chips/themes/shared/_bootstrap.scss | Updates focus token usage and adds outlined styling overrides. |
| projects/igniteui-angular/chips/src/chips/themes/dark/_material.scss | Adds dark Material outlined overrides. |
| projects/igniteui-angular/chips/src/chips/themes/dark/_indigo.scss | Adds dark Indigo outlined overrides and disabled outlined handling. |
| projects/igniteui-angular/chips/src/chips/themes/dark/_index.scss | Wires dark theme entry points for material/bootstrap/fluent/indigo. |
| projects/igniteui-angular/chips/src/chips/themes/dark/_fluent.scss | Adds dark Fluent outlined overrides. |
| projects/igniteui-angular/chips/src/chips/themes/dark/_bootstrap.scss | Adds dark Bootstrap outlined overrides. |
| projects/igniteui-angular/chips/src/chips/themes/_base.scss | Adds base outlined styling behavior and adjusts border behavior for filled chips. |
| projects/igniteui-angular/chips/src/chips/chip.spec.ts | Adds a unit test verifying the outlined host class is applied. |
| projects/igniteui-angular/chips/src/chips/chip.component.ts | Introduces the outlined input and host class binding. |
| package.json | Bumps igniteui-theming dependency to ^28.0.0-beta.4. |
| package-lock.json | Updates lockfile to reflect the igniteui-theming@28.0.0-beta.4 resolution. |
| CHANGELOG.md | Adds v22.2.0 notes including outlined chip and theming token rename breaking change. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| } | ||
| } | ||
|
|
||
| @include mx(disabled, outlined) { |
Comment on lines
84
to
89
| "express": "^5.2.1", | ||
| "fflate": "^0.8.1", | ||
| "igniteui-i18n-core": "^1.0.2", | ||
| "igniteui-theming": "^27.5.1", | ||
| "igniteui-theming": "^28.0.0-beta.4", | ||
| "igniteui-trial-watermark": "^3.1.0", | ||
| "jspdf": "^4.2.1", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes IgniteUI/igniteui-theming#591
Description
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
Chip
How Has This Been Tested?
Checklist: