Skip to content

feat(chip): add outlined version - #17517

Open
adrianptrv wants to merge 4 commits into
masterfrom
apetrov/outlined-chip
Open

feat(chip): add outlined version#17517
adrianptrv wants to merge 4 commits into
masterfrom
apetrov/outlined-chip

Conversation

@adrianptrv

Copy link
Copy Markdown
Contributor

Closes IgniteUI/igniteui-theming#591

Description

Type of Change (check all that apply):

  • New functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tests

Component(s) / Area(s) Affected:

Chip

How Has This Been Tested?

  • Unit tests
  • Manual testing

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR contains breaking changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces an outlined visual variant for the Chip component across themes, updates the underlying theming tokens for focus styling (breaking change), and provides a v22.2.0 migration + tests to automatically update affected theme usages.

Changes:

  • Adds outlined API to IgxChipComponent and exercises it in unit tests.
  • Extends chip theming SCSS across shared + dark theme variants to support outlined styling and updates focus token names.
  • Adds a v22.2.0 migration (migration-59) to rename chip-theme focus token properties, plus changelog + sample updates.

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/app/chips/chips.sample.scss Adjusts sample layout to include outlined chips in the grid.
src/app/chips/chips.sample.html Adds outlined chip examples for Angular + Web Components samples.
projects/igniteui-angular/migrations/update-22_2_0/index.ts Registers the v22.2.0 migration entry point.
projects/igniteui-angular/migrations/update-22_2_0/index.spec.ts Adds a schematic test ensuring the token renames occur.
projects/igniteui-angular/migrations/update-22_2_0/changes/theme-changes.json Defines the token rename rules for chip-theme.
projects/igniteui-angular/migrations/migration-collection.json Registers migration-59 for v22.2.0.
projects/igniteui-angular/chips/src/chips/themes/shared/_indigo.scss Updates focus token usage and adds outlined styling overrides.
projects/igniteui-angular/chips/src/chips/themes/shared/_fluent.scss Adds outlined styling overrides for Fluent shared theme.
projects/igniteui-angular/chips/src/chips/themes/shared/_bootstrap.scss Updates focus token usage and adds outlined styling overrides.
projects/igniteui-angular/chips/src/chips/themes/dark/_material.scss Adds dark Material outlined overrides.
projects/igniteui-angular/chips/src/chips/themes/dark/_indigo.scss Adds dark Indigo outlined overrides and disabled outlined handling.
projects/igniteui-angular/chips/src/chips/themes/dark/_index.scss Wires dark theme entry points for material/bootstrap/fluent/indigo.
projects/igniteui-angular/chips/src/chips/themes/dark/_fluent.scss Adds dark Fluent outlined overrides.
projects/igniteui-angular/chips/src/chips/themes/dark/_bootstrap.scss Adds dark Bootstrap outlined overrides.
projects/igniteui-angular/chips/src/chips/themes/_base.scss Adds base outlined styling behavior and adjusts border behavior for filled chips.
projects/igniteui-angular/chips/src/chips/chip.spec.ts Adds a unit test verifying the outlined host class is applied.
projects/igniteui-angular/chips/src/chips/chip.component.ts Introduces the outlined input and host class binding.
package.json Bumps igniteui-theming dependency to ^28.0.0-beta.4.
package-lock.json Updates lockfile to reflect the igniteui-theming@28.0.0-beta.4 resolution.
CHANGELOG.md Adds v22.2.0 notes including outlined chip and theming token rename breaking change.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

}
}

@include mx(disabled, outlined) {
Comment thread package.json
Comment on lines 84 to 89
"express": "^5.2.1",
"fflate": "^0.8.1",
"igniteui-i18n-core": "^1.0.2",
"igniteui-theming": "^27.5.1",
"igniteui-theming": "^28.0.0-beta.4",
"igniteui-trial-watermark": "^3.1.0",
"jspdf": "^4.2.1",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chip: Outlined Variant

4 participants