fix(for-of): guard resize observer against non-element nodes - #17516
Open
viktorkombov wants to merge 2 commits into
Open
fix(for-of): guard resize observer against non-element nodes#17516viktorkombov wants to merge 2 commits into
viktorkombov wants to merge 2 commits into
Conversation
viktorkombov
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a virtualization teardown/attach failure in IgxForOfDirective/IgxGridForOfDirective where ResizeObserver.observe()/unobserve() could be invoked with a non-Element (notably null) when embedded views are rooted in comment anchors (e.g., Angular control-flow blocks).
Changes:
- Introduces a shared helper to resolve the actual observed
Elementfor an embedded view and skips observer calls when no element can be resolved. - Adds defensive null-guarding to observation subscription logic.
- Adds unit tests covering comment-rooted views, no-element views, and safe unobserve behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| projects/igniteui-angular/directives/src/directives/for-of/for_of.directive.ts | Centralizes observed-node resolution and guards ResizeObserver calls against non-element targets. |
| projects/igniteui-angular/directives/src/directives/for-of/for_of.directive.spec.ts | Adds unit tests validating observed-node resolution and ensuring unobserve() is skipped when no element exists. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+536
to
+540
| protected getViewObservedNode(view: EmbeddedViewRef<any>): Element { | ||
| const rootNodes = view?.rootNodes ?? []; | ||
| const elementNode = rootNodes.find(node => node?.nodeType === Node.ELEMENT_NODE); | ||
| const candidate = elementNode ?? rootNodes[0]?.nextElementSibling; | ||
| return candidate?.nodeType === Node.ELEMENT_NODE ? candidate : null; |
Comment on lines
+543
to
+546
| protected subscribeToViewObserver(target: Element) { | ||
| if (!target) { | ||
| return; | ||
| } |
Comment on lines
+1499
to
+1501
| public testGetViewObservedNode(view: any): Element { | ||
| return super.getViewObservedNode(view); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17482
Description
removeLastElem()could callResizeObserver.unobserve()withnulland throw, which left the virtualization half torn down. Same unguarded lookup was used on theobserve()side, so both now go through one helper that returnsnullwhen there's no element, and the calls are skipped in that case.Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)