Skip to content

fix(esf): let templated filter operations fill the filter menu - #17509

Merged
simeonoff merged 2 commits into
masterfrom
fix/esf-template-filter-operations-fill
Aug 19, 2026
Merged

fix(esf): let templated filter operations fill the filter menu#17509
simeonoff merged 2 commits into
masterfrom
fix/esf-template-filter-operations-fill

Conversation

@ChronosSF

Copy link
Copy Markdown
Member

No description provided.

ChronosSF and others added 2 commits August 18, 2026 13:15
The igx-excel-style-filter-operations wrapper is projected straight into
the ESF menu's flex column as a plain element, so it and the search list
inside it were sized by their own content instead of the height available
in the menu. That made the virtualized list grow by a single item per
refreshSize() frame, leaving the rendered item count dependent on how
many refreshes happened rather than on the space the list actually has.

Stretch the wrapper so the search list is sized by the flex layout in one
pass. This also applies to the pivot grid, which uses the same wrapper in
its header row.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@ChronosSF
ChronosSF requested a review from simeonoff August 18, 2026 13:34
@ChronosSF
ChronosSF marked this pull request as ready for review August 18, 2026 13:34
@ChronosSF

ChronosSF commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

@simeonoff , it seems this code existed but was either intentionally removed with the scoped style change or was removed during a wrong conflict resolution either by you or @viktorkombov . Can you please confirm if it should be there or not?

(this is the PR that fixes the broken test in master we discussed today)

@ChronosSF ChronosSF added ❌ status: awaiting-test PRs awaiting manual verification triage: blocking labels Aug 18, 2026
@viktorkombov viktorkombov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Aug 18, 2026
@simeonoff
simeonoff merged commit 1434b56 into master Aug 19, 2026
6 of 7 checks passed
@simeonoff
simeonoff deleted the fix/esf-template-filter-operations-fill branch August 19, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage: blocking version: 22.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants