fix(hierarchicalGrid): Ensure col instances created from ri cols are … - #17508
Open
MayaKirova wants to merge 1 commit into
Open
fix(hierarchicalGrid): Ensure col instances created from ri cols are …#17508MayaKirova wants to merge 1 commit into
MayaKirova wants to merge 1 commit into
Conversation
MayaKirova
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a memory leak in the Hierarchical Grid by explicitly destroying dynamically created column component instances that are cloned from Row Island declarative column definitions for child grids. This aligns the child-grid column lifecycle with the grid’s own teardown lifecycle so detached DOM/components don’t remain referenced after destruction.
Changes:
- Track
ComponentRefinstances for columns created viacreateComponent()when cloning Row Island columns into a child grid. - Include nested (column-group children) created column refs in that tracking.
- Destroy all tracked refs during
ngOnDestroy()to prevent leaked column component instances.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
144
to
148
| topLevelCols.forEach((col) => { | ||
| col.grid = this; | ||
| const ref = this._createColumn(col); | ||
| this._rowIslandColumnRefs.push(ref); | ||
| ref.changeDetectorRef.detectChanges(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…destroyed.
Closes #17502
Description
Destroy column instances that are created for child grids from row island column declarations, since they seem to remain after target grid is destroyed for some reason.
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)