refactor(igniteui-angular): enabling strict true for the library by kdinev · Pull Request #17483 · IgniteUI/igniteui-angular

kdinev · 2026-08-05T08:41:27Z

Closes #17403

Description

Motivation / Context

Type of Change (check all that apply):

Component(s) / Area(s) Affected:

How Has This Been Tested?

Unit tests
Manual testing
Automated e2e tests

Test Configuration:

Angular version:
Browser(s):
OS:

Screenshots / Recordings

Checklist:

…into strict-true

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

    if (queue.hasOwnProperty(id)) {
        const fn = queue[id];
        delete queue[id];
        fn();
    }
 };

-const listener = (event) => run(event.data);
+const listener = (event: MessageEvent) => run(event.data);


Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

…ariable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

viktorkombov · 2026-08-17T11:59:46Z

 // export { IgxRadioGroupDirective } from 'igniteui-angular/radio';
 export * from './directives/ripple/ripple.directive';
 export * from './directives/scroll-inertia/scroll_inertia.directive';
-export * from './directives/size/ig-size.directive';


It looks like IgSizeDirective was intentionally moved from the library into the demo application, but AppComponent still imports it from igniteui-angular/directives. This causes npm start to fail because the corresponding public export was removed. Could we update the demo to import the new local directive instead?

Since this also removes an existing public export, could we confirm whether any changelog or migration follow-up is needed?

I think that this was never meant to be public and I dont think anyone has ever used it. So we should be safe without changelog entry and migrations

viktorkombov · 2026-08-18T08:14:18Z

@@ -3074,7 +3075,7 @@ export abstract class IgxGridBaseDirective implements GridType,
    /**
     * @hidden
     */
-    protected _pagingState;
+    protected _pagingState!: IPagingState;


This typing change exposes a pre-existing issue in src/app/grid/grid.sample.html: it accesses grid2.pagingState?.paging?.index, but IPagingState exposes index directly. Could we update it to grid2.pagingState?.index as part of this PR? This currently causes npm start to fail.

viktorkombov · 2026-08-18T10:23:14Z

+        appTree = setupTestTree();
+    });
+
+    const migrationName = 'migration-58';


It looks like this spec runs migration-58, while the new import migration is registered as migration-59. Could we update migrationName accordingly? The current value runs the existing update-22_1_0 migration instead and causes these tests to fail.

Suggested change

const migrationName = 'migration-58';

const migrationName = 'migration-59';

viktorkombov · 2026-08-18T10:38:52Z

+    // Add remaining imports for the original entry point first
+    if (remaining.length > 0) {
+        const sortedImports = remaining.sort();
+        newImports.push(`import { ${sortedImports.join(', ')} } from '${importPath}';`);


Could we also preserve type-only imports during the rewrite? For example, import type { IGroupingDoneEventArgs } ... is currently regenerated as a regular import { IGroupingDoneEventArgs } ..., which may affect projects using verbatimModuleSyntax.

…ctive

…t path

…tion-59'

viktorkombov · 2026-08-18T13:40:49Z

+    // Add moved imports
+    for (const [entryPoint, imports] of entryPointGroups) {
+        const sortedImports = imports.sort();
+        newImports.push(`import { ${sortedImports.join(', ')} } from '${source.basePackage}/${entryPoint}';`);


Could we merge migrated symbols into an existing import from the target entry point? For example, when IgxSummaryResult is already imported from igniteui-angular/core, migrating the summary operands currently creates a second import from the same module.

…s and merging

kdinev and others added 2 commits August 5, 2026 11:02

refactor(igniteui-angular): enabling strict: true for the lib

cd2a2f9

Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …

a644025

…into strict-true

Copilot AI review requested due to automatic review settings August 5, 2026 08:41

Copilot AI reviewed Aug 5, 2026

github-code-quality Bot found potential problems Aug 5, 2026

View reviewed changes

Comment thread projects/igniteui-angular/core/src/services/overlay/overlay.ts Fixed

github-advanced-security AI found potential problems Aug 5, 2026

View reviewed changes

Comment thread projects/igniteui-angular/grids/core/src/setImmediate.ts

if (queue.hasOwnProperty(id)) {

const fn = queue[id];

delete queue[id];

fn();

}

};

const listener = (event) => run(event.data);

const listener = (event: MessageEvent) => run(event.data);

chore(*): accidentally committed css files from scoped styles

2636911

Copilot AI review requested due to automatic review settings August 5, 2026 08:49

Copilot AI reviewed Aug 5, 2026

Potential fix for pull request finding 'Useless assignment to local v…

7771f6a

…ariable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Copilot AI review requested due to automatic review settings August 5, 2026 08:50

Copilot AI reviewed Aug 5, 2026

kdinev requested a review from Copilot August 5, 2026 08:51

Copilot AI reviewed Aug 5, 2026

fix(lint): fixing unsed imports

bec986f

Copilot AI review requested due to automatic review settings August 5, 2026 10:33

Copilot AI reviewed Aug 5, 2026

kdinev added refactoring version: 22.1.x labels Aug 5, 2026

test(*): fixing a lot of tests

eccf397

Copilot AI review requested due to automatic review settings August 5, 2026 14:34

Copilot AI reviewed Aug 5, 2026

fix(*): more fixes and fixes

868c2e7

Copilot AI review requested due to automatic review settings August 5, 2026 15:56

Copilot AI reviewed Aug 5, 2026

chore(*): fixing lint error

55b8102

Copilot AI review requested due to automatic review settings August 5, 2026 16:08

Copilot AI reviewed Aug 5, 2026

kdinev changed the title ~~refactor(igniteui-angular): enabling strict: true for the library~~ refactor(igniteui-angular): enabling strict true for the library Aug 5, 2026

fix(query-builder): this should fix the tests

e65469e

Copilot AI reviewed Aug 6, 2026

fix(igniteui-angular-extras): tests were failing

90ac7ec

Copilot AI review requested due to automatic review settings August 6, 2026 13:36

Copilot AI reviewed Aug 6, 2026

fix(igniteui-angular-extras): conditional styles were regressed

d7cbe27

Copilot AI review requested due to automatic review settings August 7, 2026 07:48

Copilot AI reviewed Aug 7, 2026

test(summaries): increasing summaries with grouping coverage

773c43c

Copilot AI review requested due to automatic review settings August 7, 2026 09:02

Copilot AI reviewed Aug 7, 2026

rkaraivanov self-requested a review August 7, 2026 13:00

rkaraivanov and others added 3 commits August 14, 2026 15:57

Merge remote-tracking branch 'origin/master' into strict-true

fd714ee

chore: Post-merge fixes and cleanups

628908e

Merge branch 'master' into strict-true

5836caa

viktorkombov reviewed Aug 17, 2026

View reviewed changes

Comment thread projects/igniteui-angular/directives/src/directives/tooltip/tooltip-target.directive.ts Outdated

viktorkombov reviewed Aug 17, 2026

View reviewed changes

fix: add type annotation for 'node' parameter in getBorder method

1550b2d

viktorkombov reviewed Aug 18, 2026

View reviewed changes

Merge branch 'master' into strict-true

72f48ba

viktorkombov reviewed Aug 18, 2026

View reviewed changes

mddragnev added 4 commits August 18, 2026 15:59

fix(tooltip): update target setter to accept string or IgxTooltipDire…

0cb8128

…ctive

fix: remove redundant import of IgSizeDirective and add correct impor…

ee6bf99

…t path

chore(sample): update ngModel binding for pagination state

8bdc67d

chore(migration): update migration name from 'migration-58' to 'migra…

fe8baca

…tion-59'

viktorkombov reviewed Aug 18, 2026

View reviewed changes

mddragnev and others added 4 commits August 19, 2026 12:06

fix(migration): enhance import migration logic to support type import…

76cbe99

…s and merging

Merge branch 'master' into strict-true

958abee

fix: Fix build because of tooltip-target

c05f530

Merge branch 'master' into strict-true

11300dc

	const migrationName = 'migration-58';
	const migrationName = 'migration-59';

Uh oh!

Conversation

kdinev commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation / Context

Type of Change (check all that apply):

Component(s) / Area(s) Affected:

How Has This Been Tested?

Test Configuration:

Screenshots / Recordings

Checklist:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

viktorkombov Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

mddragnev Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

viktorkombov Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

viktorkombov Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

viktorkombov Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

viktorkombov Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

kdinev commented Aug 5, 2026 •

edited

Loading