fix(*): add mustCoerceToInt to relevant props - 21.2.x#16625
Merged
Conversation
IMinchev64
added
❌ status: awaiting-test
|
There has been no recent activity and this PR has been marked inactive. |
github-actions
Bot
added
the
status: inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Adds mustCoerceToInt metadata markers to selected enum-typed properties so downstream Blazor metadata resolves enum values as numbers (instead of strings).
Changes:
- Annotate pivot grid dimension-change event args to coerce
PivotDimensionTypeto an int. - Annotate grid pinning config positions to coerce pinning enums to ints.
- Annotate overlay
PositionSettingsalignment properties and filtering expression tree operator/type to coerce enums to ints.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
projects/igniteui-angular/grids/core/src/pivot-grid.interface.ts |
Adds mustCoerceToInt marker for dimensionCollectionType metadata. |
projects/igniteui-angular/grids/core/src/common/grid.interface.ts |
Adds mustCoerceToInt markers for IPinningConfig enum properties. |
projects/igniteui-angular/core/src/services/overlay/utilities.ts |
Adds mustCoerceToInt markers for PositionSettings alignment enums. |
projects/igniteui-angular/core/src/data-operations/filtering-expressions-tree.ts |
Adds mustCoerceToInt markers for filtering operator and tree type enum properties. |
IMinchev64
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attribute is needed so the metadata descriptions which are used by Blazor can be updated which would resolve the enum values as numbers instead of strings.
Related to: https://infragistics.visualstudio.com/Indigo_Platform/_workitems/edit/34678
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)