Skip to content

refactor(grids): Move all elements specific code to angular-element's source#15304

Merged
dkamburov merged 48 commits into
masterfrom
mkirova/feat-15235
Jun 18, 2026
Merged

refactor(grids): Move all elements specific code to angular-element's source#15304
dkamburov merged 48 commits into
masterfrom
mkirova/feat-15235

Conversation

@MayaKirova

@MayaKirova MayaKirova commented Jan 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #15235
Goes with: https://github.com/IgniteUI/igniteui-api-analyzer/pull/129

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@dkamburov dkamburov requested a review from skrustev February 4, 2025 09:21
skrustev
skrustev previously approved these changes Feb 13, 2025
View reviewed changes
@MarielaTihova MarielaTihova added the ✅ status: verified Applies to PRs that have passed manual verification label Mar 17, 2025
@dkamburov

dkamburov commented Mar 26, 2025

Copy link
Copy Markdown
Contributor

@MayaKirova there is a conflict here

@skrustev skrustev self-requested a review April 15, 2025 07:47
skrustev
skrustev previously approved these changes Apr 15, 2025
View reviewed changes
@dkamburov

dkamburov commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

@MayaKirova please resolve the conflicts here

@github-actions

github-actions Bot commented Aug 17, 2025

Copy link
Copy Markdown

There has been no recent activity and this PR has been marked inactive.

@github-actions github-actions Bot added the status: inactive Used to stale issues and pull requests label Aug 17, 2025
@dkamburov dkamburov removed the status: inactive Used to stale issues and pull requests label Aug 19, 2025
@skrustev skrustev self-requested a review August 26, 2025 11:12
skrustev
skrustev previously approved these changes Aug 26, 2025
View reviewed changes
@dkamburov

dkamburov commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

@MayaKirova there is a conflict here

@MayaKirova
Merge pull request #17165 from IgniteUI/skrastev/feat-15235-aliaz
1ca0231 
fix(elements): Apply wc alternate name tag instead.
@skrustev skrustev added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 8, 2026
@skrustev

skrustev commented Apr 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@MayaKirova It seems like the columnsAutogenerated event doesn't fire for the RowIslands in Elements. I tested it with a previous version of the WC Grid and it seems to be working. For some reason also after building in the analyzer the Hierarchical Grid event doesn't fire, even though it fires here in the samples. Not sure if I'm doing something wrong

@skrustev skrustev added ❌ status: awaiting-test PRs awaiting manual verification and removed ✅ status: verified Applies to PRs that have passed manual verification labels Apr 9, 2026
@MayaKirova

MayaKirova commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

@skrustev columnsAutogenerated should re-emit for row islands now.

@skrustev skrustev added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 14, 2026
@MayaKirova MayaKirova requested a review from damyanpetev April 16, 2026 07:46
@damyanpetev damyanpetev changed the title Move all elements specific members from the angular grids into angular-element's source. refactor(grids): Move all elements specific code to angular-element's source Jun 18, 2026
@damyanpetev damyanpetev added squash-merge Merge PR with "Squash and Merge" option version: 22.0.x and removed version: 20.0.x labels Jun 18, 2026
@dkamburov dkamburov merged commit f05e700 into master Jun 18, 2026
6 of 10 checks passed
@dkamburov dkamburov deleted the mkirova/feat-15235 branch June 18, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@damyanpetev damyanpetev damyanpetev approved these changes

@skrustev skrustev Awaiting requested review from skrustev

+1 more reviewer

@github-code-quality github-code-quality[bot] github-code-quality[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dkamburov dkamburov

@skrustev skrustev

Labels

💠 grid: elements refactoring squash-merge Merge PR with "Squash and Merge" option version: 22.0.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Elements] Move all elements specific members from the angular grids into angular-element's source.

8 participants

@MayaKirova @dkamburov @skrustev @damyanpetev @MarielaTihova @kdinev