Skip to content

Prepare admin app for Vercel deployment#28

Open
IgnazioDS wants to merge 1 commit intomainfrom
branch/vercel-admin-ready
Open

Prepare admin app for Vercel deployment#28
IgnazioDS wants to merge 1 commit intomainfrom
branch/vercel-admin-ready

Conversation

@IgnazioDS
Copy link
Copy Markdown
Owner

Summary

  • add a real Next.js ESLint setup for the admin app
  • harden admin cloud env validation and proxy runtime config for Vercel
  • document the Vercel root-directory and env setup for apps/admin

Verification

  • npm run lint
  • npm run build

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb509f3b40

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +23 to +24
const rawValue =
process.env.CLOUD_BASE_URL || process.env.NEXT_PUBLIC_CLOUD_BASE_URL || '';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Apply fallback after sanitizing CLOUD_BASE_URL

Select the fallback only after normalizing CLOUD_BASE_URL; with the current process.env.CLOUD_BASE_URL || process.env.NEXT_PUBLIC_CLOUD_BASE_URL order, a whitespace-only or quote-wrapped empty CLOUD_BASE_URL is treated as present and prevents fallback, causing startup to fail even when NEXT_PUBLIC_CLOUD_BASE_URL is valid. The prior implementation trimmed before ||, so this is a behavior regression for misconfigured-but-recoverable env setups.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant