Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb509f3b40
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const rawValue = | ||
| process.env.CLOUD_BASE_URL || process.env.NEXT_PUBLIC_CLOUD_BASE_URL || ''; |
There was a problem hiding this comment.
Apply fallback after sanitizing CLOUD_BASE_URL
Select the fallback only after normalizing CLOUD_BASE_URL; with the current process.env.CLOUD_BASE_URL || process.env.NEXT_PUBLIC_CLOUD_BASE_URL order, a whitespace-only or quote-wrapped empty CLOUD_BASE_URL is treated as present and prevents fallback, causing startup to fail even when NEXT_PUBLIC_CLOUD_BASE_URL is valid. The prior implementation trimmed before ||, so this is a behavior regression for misconfigured-but-recoverable env setups.
Useful? React with 👍 / 👎.
Summary
Verification