Fix tests for modulation parameters - #8
Conversation
Co-authored-by: Isaac Hill isaachilly@outlook.com
6d86ab0 to
3e84c87
Compare
FreddieAkeroyd
changed the title
658b029 to
877ab34
Compare
| DB += aeroflex_2023A.db | ||
| DB += aeroflex_2030.db | ||
| DB += aeroflex_common.db | ||
| DB += aeroflex_modulation.db |
There was a problem hiding this comment.
if this is now including additional dbs should we add it to release notes?
|
The db doesn't actually add anything new user facing, the code was refactored some time ago and the muon changes were not added back onto main, partly because there are several aeroflex models and though they all have similar commands they don't all behave the same (as in if it has multiple channels reply to a command can change, also FM is FM1 and FM2). When the dbs's were updated the Makefile change was missed - the db was already there and being used on muons, just not in the Makefile. So bottom line is its addition is just correcting a mistake in the build system that when added makes the results identical to that already deployed. |
|
The linked ticket makes it sound more than it is, the fuctionality has existed for a while and used my muons hence i don't feel needs release notes |
3 participants
See ISISComputingGroup/IBEX#8015