fix: include directory paths in file searches - #12685
Open
youseihuayu-wonderful wants to merge 2 commits into
Open
youseihuayu-wonderful wants to merge 2 commits into
youseihuayu-wonderful wants to merge 2 commits into
Conversation
pdurbin
reviewed
Sep 10, 2026
| @@ -6,6 +6,26 @@ A Dataverse installation requires Solr to be operational at all times. If you st | |||
| .. contents:: Contents: | |||
| :local: | |||
|
|
|||
Member
There was a problem hiding this comment.
I'm just adding this under "doc" but @youseihuayu-wonderful can you please add a release note snippet? Please see https://guides.dataverse.org/en/6.11/developers/version-control.html#writing-release-note-snippets
Here's a good one to look at: https://github.com/Recherche-Data-Gouv/dataverse/blob/aa3f855a6da3a95c959b3d23ce06ad22e74316cd/doc/release-notes/8941-adding-fileCount-in-solr.md
pdurbin
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds directory-path matching to dataset and site-wide file searches. Filename/description searches and access checks are unchanged.
Which issue(s) this PR closes:
Closes IQSS/dataverse-frontend#1062
Special notes for your reviewer:
Update and reload the Solr schema before deploying, then reindex existing files. No PostgreSQL migration.
Suggestions on how to test this:
Search for a directory name that does not appear in the filenames or descriptions, e.g.
Figure1. Verified both search pages; 17 targeted tests passed locally. The strict docs build reports two existing duplicate-target warnings.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No layout changes.
Is there a release notes update needed for this change?:
Yes: directory search support and the required Solr update/reindex.
Additional documentation:
Updated user/API docs, API changelog, and Solr upgrade instructions.