Conversation
github-actions
bot
added
Croissant
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
pdurbin
force-pushed
the
12014-croissant-1.1
branch
2 times, most recently
from
c94c6ee to
97ff858
Compare
This comment has been minimized.
This comment has been minimized.
pdurbin
force-pushed
the
12014-croissant-1.1
branch
from
97ff858 to
b98a3be
Compare
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
landreev
left a comment
landreev
left a comment
There was a problem hiding this comment.
I'm assuming Jenkins test failed for unrelated reasons last time the branch was touched.
I'm going to assume that QA will involve confirming that all the tests are passing.
Looks good overall!
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
"For namespace URLs, we use http:// (that's an issue discussed at length in the schema.org community, and you can probably find an older issue about it.)" -- mlcommons/croissant#929 (review)
The wikidata namespace is unused and doesn't appear in the 1.0 or 1.1 spec. (It was in a titanic example for 1.0). Remove.
pdurbin
force-pushed
the
12014-croissant-1.1
branch
from
b98a3be to
12e9553
Compare
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
| "conformsTo": "http://mlcommons.org/croissant/1.1", | ||
| "name": "Cars", | ||
| "url": "https://doi.org/10.5072/FK2/CY7BWA", | ||
| "creator": [ |
There was a problem hiding this comment.
I'm just leaving a note here at the bottom about the state of Jenkins and API tests that we can resolve later.
They are currently failing at https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-12214/6/consoleFull with this:
TASK [dataverse : STORAGE | Run docker-compose up MinIO] *********************
fatal: [localhost]: FAILED! => {"changed": false, "errors": [], "module_stderr": "", "module_stdout": "latest: Pulling from minio/minio\n", "msg": "Error starting project unknown: failed to copy: httpReadSeeker: failed open: unexpected status from GET request to https://quay.io/v2/minio/minio/blobs/sha256:c1bc68842c41cb716734641f75dc37d629f05df5f812a8cc2e7e0370d4e833ec: 502 Bad Gateway"}
There was a problem hiding this comment.
https://status.redhat.com says quay.io is under maintenance:
There was a problem hiding this comment.
From https://status.redhat.com quay.io should be back up:
I kicked off another run: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-12214/7/
There was a problem hiding this comment.
Good news! API tests were able to run. They are passing on this PR: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-12214/7/testReport/
4 participants
What this PR does / why we need it:
The Croissant metadata export format has been updated from version 1.0 to 1.1.
Summary statistics (mean, min, max, etc.) are now included for tabular files that were successfully ingested.
Which issue(s) this PR closes:
Special notes for your reviewer:
croissantformat are noted in the API changelog.croissantSlimformat, which doesn't include files or variables.Suggestions on how to test this:
croissantandcroissantSlimexports.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Yes, included.
Additional documentation:
Preview doc changes at https://dataverse-guide--12214.org.readthedocs.build/en/12214/api/changelog.html