Repository navigation
Stream NC1 lines and template tokens to avoid allocating on hostile input - #37
Merged
Merged
Conversation
mahach666
commented
Nov 14, 2026
mahach666
left a comment
Contributor
Author
There was a problem hiding this comment.
Do not merge yet: template token streaming improves early rejection, but the NC1 path still buffers an entire malformed block. The case below remains an unaddressed part of the hostile-input allocation problem in #6.
…d blocks Rejects invalid AK/BO lines immediately without buffering remaining lines of a bad block. Adds early-rejection allocation test.
mahach666
commented
Nov 14, 2026
mahach666
left a comment
Contributor
Author
There was a problem hiding this comment.
The original whole-block allocation issue is fixed: the 500,000-empty-line regression now passes on net8.0/net10.0. However, the newly added allocation test is flaky in the normal parallel suite; the attached failure occurred during this recheck.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stream DSTV lines and template tokens instead of holding the entire input as lists of lines or tokens, addressing issue #6.
ef struct LineReader, parsing blocks and verifying ST/body lines incrementally.
Closes #6