Repository navigation
Use gzip trailer unpacked size as initial buffer capacity (fixes #7) - #29
Merged
Merged
Conversation
mahach666
commented
Nov 14, 2026
mahach666
left a comment
Contributor
Author
There was a problem hiding this comment.
Do not merge yet: the allocation change trusts the gzip trailer before validating the compressed data. The issue below was reproduced with a synthetic input; the same allocation check passes on main.
Bound initial buffer size and grow as bytes are inflated to prevent forged ISIZE from allocating large buffers on invalid data. Add regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allocate the output buffer with initial capacity matching the gzip trailer's declared unpacked size (size, already capped by maxUnpacked), avoiding repeated Array.Resize doubling and eliminating 2x peak memory allocation while preserving CRC and length validation.