Repository navigation
Conversation
The workflow pushes the NuGet packages before the GitHub release is created (a refused first publication can be fixed and the job re-run), publishes a hyphen tag as a prerelease, and checks the changelog section before anything is published. The README states the ecosystem position and the adapter trigger; CONTRIBUTING describes the new order; CHANGELOG records the change.
The separation of responsibilities of the target architecture: the core stays a leaf, the scene mapping lives in src/PlaIO.Scene, the viewer stays IOViewer. PlaSceneReader.Read(path) produces a valid scene of one model (the frozen Key derivation, SourceFormat pla/pln, the container-only diagnostic) and no elements while the container reader decodes none. The project is IsPackable=false and is not published; it ships on a PlaIO tag when the reader decodes elements and geometry. Tests in PlaIO.Tests freeze the key derivation; docs/scene.md documents the mapping, the limits and the publication rule.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes and why
Aligns the repository with the IOExtend target architecture (the org profile "Architecture" section and the
2026-11-12-ioextend-target-architecturedocument) — the transition RvtIO and NwcIO have already started. Two parts:1. Release choreography (§2.4)
release.ymlpushes the NuGet packages before the GitHub release is created. A refused first publication of apackage id can be fixed and the job re-run, because
--skip-duplicatemakes the push repeatable and no releaseexists yet. The changelog section for the version is checked (release notes extracted) before anything is published.
v0.2.0-preview.1, is published as a GitHub prerelease(
v0.1.0was published as a full release despite being a preview).[Unreleased].NUGET_USERvalidation and reads the login user from the repository variable,where RvtIO and NwcIO hard-code the profile name.
2. The core / scene / viewer separation
(
DirectoryJson) is the engine-native dump the architecture keeps in engines.src/PlaIO.Scene(namespace PlaIO.Scene), the adapter where the scene mapping lives as it did forRvtIO.SceneandNwcIO.Scene:PlaSceneReader.Read(path)turns a container into anIOSceneSceneDocument—one model per file, no elements yet. The scene holds no guesses; the
container-onlydiagnostic (Info) says what ismissing. The
Keyderivation is frozen and covered by identity tests:PlaSceneOptions.ModelKey, else the filename with its extension.
IsPackable=false: the adapter does not publish and no NuGet id is committed until the reader decodes elementsand geometry — the adapter trigger of the target architecture ("PlaIO decodes geometry / has elements to export /
has a writer"). This is how IfcIO.Scene and RvtIO.Scene started (B3/B4: unpackable until the gate).
IOScene [0.1.1, 0.2.0-0.0)+NoWarn NU5104inDirectory.Packages.props, the exactengine pin target (
PinProjectReferencesExactly) ready for the flip,docs/scene.md,docfx.jsonanddocs.ymlpaths, tests in
tests/PlaIO.Tests(the RvtIO style:RvtSceneIdentitySampleTestslives inRvtIO.Tests).docs/dependencies.mddocuments the adapter'sIOScenedependency and fixesa stale Test.Sdk version in it.
How it was checked
dotnet build PlaIO.slnx -c Releasehas no warningsdotnet test PlaIO.slnx -c Releasepasses (152 passed, 13 skipped — the sample tests gated byPLAIO_TEST_FILES;6 new adapter tests, identity literals included)
plaio info,plaio blocksandplaio directoryon the same files is identical before and after — noreader or CLI code is touched, so the outputs are identical by construction
tools/pack-release.ps1produces the same 9 artifacts (PlaIO.Sceneis not packed whileIsPackable=false)dotnet docfx docfx.json --warningsAsErrorsbuilds with 0 warnings (the adapter API page included)PlaIO-specific early
NUGET_USERvalidation and the variable-based login user