Skip to content

Keep the scene adapter on the public NwcIO API - #252

Merged
mahach666 merged 1 commit into
mainfrom
codex/nwcio-scene-public-api
Nov 18, 2026
Merged

mahach666 merged 1 commit into
mainfrom
codex/nwcio-scene-public-api

Conversation

@mahach666

Copy link
Copy Markdown
Collaborator

Changes

  • Expose the full path of a document opened by filename through NwcDocument.GetLoadedPath(). The authoring path stored in the file remains available through NwcFileInfo.SourcePath. Streams and in-memory documents return null.
  • Use the public method for scene assembly conversion and remove NwcIO.Scene from the engine's friend assemblies. Synthetic fixtures retain their test-only access.
  • Check file-backed and in-memory assemblies in the scene regression tests, including the existing model keys and paths.

Verification

  • Release build, solution tests and pack on Windows, targeting .NET 8 and .NET 10.
  • 1,286 engine tests and 98 scene tests passed per framework. Twelve real-file tests per framework were skipped before and after the change.
  • git diff --check.

@mahach666
mahach666 merged commit cadc955 into main Nov 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant