Repository navigation
feat(parser): decode .nwd partition nodes and Navisworks 2026 geometry variants - #251
Merged
Merged
Conversation
…y variants - Class 32 (LcOaPartition) is a class-53 body behind one more string, with a trailer after its children that holds no objects; it is read for length. .nwd scene trees now open with BuildSceneTree on. - A fragment without a pose sits at its class-93 centre c. - The colour slot is optional in triangle and line records. - One of the two quantised UV bit widths may be 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for NwcIO, and for keeping the grammar and the notes so precise: they are what made these fixes possible.
Closes #250. Details of what was found are in the issue.
Summary
--no-treehint and theNotSupportedExceptionwrapper inNwcIO.Scenego away, since nothing throws it any more.--no-treeitself stays.RealFixtureTestsopens.nwdfixtures with their tree.Evidence
ModelGraphReader,PartitionPropsand Scene tests now open the partition file instead of expectingNotSupportedException. The partition fixture gained leaves at preorder 2 and 7, so F1's fragments link to them..nwdfrom the issue failed in the geometry reader even with--no-tree, and in the tree reader with it.After: it opens with the tree, every geometry record decoded, no diagnostics.
NwcIO.Tests: 1286 passed, 11 skipped.NwcIO.Scene.Tests: 98 passed, 1 skipped.dotnet format whitespace --verify-no-changesis clean on the changed files.mainunder net8.0.RealFixtureTestswith that file as the only fixture:.nwc-only theory has no data, as expected.Merge Danger
Door: two-way. Reading only; no writer, API or package-shape change. Callers that caught
NotSupportedExceptionto retry withBuildSceneTree = falsenow simply get the tree.Blast Radius:
.nwdfiles with partition nodes..nwdfixtures come from other versions, theRealFixtureTestschange will show quickly whether their trailers match.InvalidDataExceptionat the trailer instead of aNotSupportedException.