Refactor support for orcidio as a new type of module. - #24
Open
gouttegd wants to merge 1 commit into
Open
Conversation
Now that we can exclude individual import modules from the merged
module, we no longer need to treat ORCIDIO as a completely ad-hoc thing,
that is neither an import nor a component. Instead, we can treat merely
as a type of import module.
That is, instead of
```yaml
orcidio_support: true
```
the configuration should now be
```yaml
import_group:
products:
- id: orcidio
```
We automatically recognise `orcidio` as a module of type `orcidio`,
which can then be treated as any other import module -- allowing us to
remove most of the orcidio-specific code everywhere: all we need to keep
is the custom rule to create the import module itself.
Just in case someone would want to import a module called `orcidio` that
is _not_, in fact, the ORCIDIO from `https://w3id.org/orcidio/`, we
don't do anything special if the module is declared with an explicit
import type. For example:
```yaml
import_group:
products:
- id: orcidio
module_type: slme
```
This would be treated as a standard SLME module from an hypothetical
`orcidio` ontology (which would here be expected to be located at
`http://purl.obolibrary.org/obo/orcidio.owl`, since there's no
`mirror_from`).
When base merging is enabled, the ORCIDIO module is automatically
excluded from the merged module, since it requires its own extraction
method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This PR is built on top on #23.)
Now that we can exclude individual import modules from the merged module, we no longer need to treat ORCIDIO as a completely ad-hoc thing, that is neither an import nor a component. Instead, we can treat merely as a type of import module.
That is, instead of
the configuration should now be
We automatically recognise
orcidioas a module of typeorcidio, which can then be treated as any other import module – allowing us to remove most of the orcidio-specific code everywhere: all we need to keep is the custom rule to create the import module itself.Just in case someone would want to import a module called
orcidiothat is not, in fact, the ORCIDIO fromhttps://w3id.org/orcidio/, we don't do anything special if the module is declared with an explicit import type. For example:This would be treated as a standard SLME module from an hypothetical
orcidioontology (which would here be expected to be located athttp://purl.obolibrary.org/obo/orcidio.owl, since there's nomirror_from).When base merging is enabled, the ORCIDIO module is automatically excluded from the merged module, since it requires its own extraction method.