Repository navigation
BookingPool 48004: Unify Booking Timestamp Handling - #12253
Open
matheuszych wants to merge 2 commits into
Open
matheuszych wants to merge 2 commits into
matheuszych wants to merge 2 commits into
Conversation
See: https://mantis.ilias.de/view.php?id=48004 Booking reservation timestamps were handled inconsistently across BookingManager: some code paths stored or displayed the slot end as end-1 second (e.g. 11:59:59 instead of 12:00:00), while others used the full inclusive end. This caused mismatches between views, availability checks, and stored data. All write, display, and action paths now use the same inclusive from/to values without +1/-1 second adjustments. A data migration (`ilBookingManagerReservationTimestampMigration`) normalizes existing rows where timestamps are not minute-aligned (MOD(ts, 60) <> 0).
See: https://mantis.ilias.de/view.php?id=48004 Booking ends are stored inclusive. The migration moves a legacy second-59 end onto the next minute. The personal calendar added one second to every booking end, so an all-day slot at 00:00:00 also appeared on the next day. modifyEvent returns the entry unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://mantis.ilias.de/view.php?id=48004
Booking reservation timestamps were handled inconsistently across BookingManager: some code paths stored or displayed the slot end as end-1 second (e.g. 11:59:59 instead of 12:00:00), while others used the full inclusive end. This caused mismatches between views, availability checks, and stored data.
All write, display, and action paths now use the same inclusive from/to values without +1/-1 second adjustments. A data migration (
ilBookingManagerReservationTimestampMigration) normalizes existing rows where timestamps are not minute-aligned (MOD(ts, 60) <> 0)./cc @thojou