Test 47625: Fix unit handling in advanced rating evaluation#11594
Open
lukas-heinrich wants to merge 1 commit into
Open
Test 47625: Fix unit handling in advanced rating evaluation#11594lukas-heinrich wants to merge 1 commit into
lukas-heinrich wants to merge 1 commit into
Conversation
dsstrassner
added
php
Member
|
Just a short question: why is this PR tagged with 'Authorities'? |
kergomard
added
bugfix
and removed
authorities
Contributor
|
This is plain and simply wrong. I think we simply fat-fingered this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone,
This PR relates to Mantis ticket 47625. The behaviour can only be reproduced if the ‘Advanced rating’ mode has been enabled for the formula question.
It seems to me that the issue has been addressed in commit c5c9537 by @matheuszych. However in 723a7c8, some operands were swapped, which, in my POV, leads to the problem described in the ticket. In the
getReachedPointsmethod,answer_unitwas compared withanswer_unitto verify the result. Consequently, this always returned true, and the result was awarded the full marks for the correct unit.As always, I look forward to your feedback and comments on these changes.
Best,
@lukas-heinrich
/cc @thojou