Skip to content

Comments

NW 46577: Removes initModal js function and its usages#11140

Closed
matheuszych wants to merge 1 commit intoILIAS-eLearning:release_11from
matheuszych:nw/46577
Closed

NW 46577: Removes initModal js function and its usages#11140
matheuszych wants to merge 1 commit intoILIAS-eLearning:release_11from
matheuszych:nw/46577

Conversation

@matheuszych
Copy link
Contributor

https://mantis.ilias.de/view.php?id=46577

Aims to remove initModal js function and its usages.
@thojou

@matheuszych
Copy link
Contributor Author

Hello @alex40724 ,
could you please take a look at these changes?

Best regards
@matheuszych

@matheuszych
Copy link
Contributor Author

@alex40724
Copy link
Member

alex40724 commented Feb 22, 2026

@matheuszych Thanks for the PR. I do not think that we can remove this. I tested it and the standard buttons that remain (if we add input to the modal directly in the adapter) are always submitting the form synchronously, there is not async/modal replacement behaviour that you need, e.g. in the booking pool when booking recurrences. So your change will break this (check the recurrence booking workflow).

We still need to keep our buttons and remove the standard one. However the init function did a bad job in it and removed also buttons that we want to keep (like the delete button for the news).

I committed a fix for this here: 1e2cc84

This has been an issue already in ILIAS 10.

@alex40724 alex40724 closed this Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants