NW 46577: Removes initModal js function and its usages#11140
NW 46577: Removes initModal js function and its usages#11140matheuszych wants to merge 1 commit intoILIAS-eLearning:release_11from
Conversation
638e111 to
4c5df7e
Compare
|
Hello @alex40724 , Best regards |
|
@matheuszych Thanks for the PR. I do not think that we can remove this. I tested it and the standard buttons that remain (if we add input to the modal directly in the adapter) are always submitting the form synchronously, there is not async/modal replacement behaviour that you need, e.g. in the booking pool when booking recurrences. So your change will break this (check the recurrence booking workflow). We still need to keep our buttons and remove the standard one. However the init function did a bad job in it and removed also buttons that we want to keep (like the delete button for the news). I committed a fix for this here: 1e2cc84 This has been an issue already in ILIAS 10. |
https://mantis.ilias.de/view.php?id=46577
Aims to remove initModal js function and its usages.
@thojou