Skip to content

T&A 47005: Fixes issues with check button not being shown in test player #11137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matheuszych wants to merge 1 commit into
base: release_11
Choose a base branch
from
+21 −2
Open

T&A 47005: Fixes issues with check button not being shown in test player #11137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions components/ILIAS/Test/classes/class.ilTestPlayerAbstractGUI.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2364,6 +2364,10 @@ protected function buildReadOnlyStateQuestionNavigationGUI($question_id): ilTest
$this->ui_renderer
);

$navigationGUI->setFeedbackButtonEnabled(
$this->object->getMainSettings()->getQuestionBehaviourSettings()->isAnyInstantFeedbackOptionEnabled()
);

if (!$this->isParticipantsAnswerFixed($question_id)) {
$navigationGUI->setEditSolutionCommand(ilTestPlayerCommands::EDIT_SOLUTION);
}
Expand Down Expand Up @@ -2398,6 +2402,10 @@ protected function buildEditableStateQuestionNavigationGUI($question_id): ilTest
$this->ui_renderer
);

$navigation_gui->setFeedbackButtonEnabled(
$this->object->getMainSettings()->getQuestionBehaviourSettings()->isAnyInstantFeedbackOptionEnabled()
);

// fau: testNav - add a 'revert changes' link for editable question
$navigation_gui->setRevertChangesLinkTarget($this->ctrl->getLinkTarget($this, ilTestPlayerCommands::REVERT_CHANGES));

Expand Down
13 changes: 12 additions & 1 deletion components/ILIAS/Test/classes/class.ilTestQuestionNavigationGUI.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ class ilTestQuestionNavigationGUI
private bool $question_marked = false;
private bool $anything_rendered = false;
private ?Signal $show_discard_modal_signal = null;
private bool $feedback_button_enabled = false;

public function __construct(
protected ilLanguage $lng,
Expand Down Expand Up @@ -122,6 +123,16 @@ private function getShowDiscardModalSignal(): Signal
return $this->show_discard_modal_signal ?? new SignalImplementation('');
}

public function setFeedbackButtonEnabled(bool $feedback_button_enabled): void
{
$this->feedback_button_enabled = $feedback_button_enabled;
}

public function isFeedbackButtonEnabled(): bool
{
return $this->feedback_button_enabled;
}

public function getActionsHTML(): string
{
$tpl = $this->getTemplate('actions');
Expand Down Expand Up @@ -189,7 +200,7 @@ public function getHTML(): string
);
}

if ($this->instant_feedback_command === ilTestPlayerCommands::SHOW_INSTANT_RESPONSE) {
if ($this->isFeedbackButtonEnabled()) {
$this->renderInstantFeedbackButton(
$tpl,
$this->instant_feedback_command,
Expand Down
2 changes: 1 addition & 1 deletion components/ILIAS/Test/src/Settings/MainSettings/SettingsQuestionBehaviour.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ public function withInstantFeedbackSolutionEnabled(bool $instant_feedback_soluti
return $clone;
}

private function isAnyInstantFeedbackOptionEnabled(): bool
public function isAnyInstantFeedbackOptionEnabled(): bool
{
return $this->getInstantFeedbackPointsEnabled()
|| $this->getInstantFeedbackGenericEnabled()
Expand Down