T&A 47011: Fixes inline feedback and best possible solution in results#11130
Open
bidzanaaron wants to merge 1 commit intoILIAS-eLearning:release_11from
Open
T&A 47011: Fixes inline feedback and best possible solution in results#11130bidzanaaron wants to merge 1 commit intoILIAS-eLearning:release_11from
bidzanaaron wants to merge 1 commit intoILIAS-eLearning:release_11from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix https://mantis.ilias.de/view.php?id=47011.
As far as I have found out, since the creation of the getSolutionOutput variables occurred outside the foreach loop, when changed, they would reflect the state onto the next executions. If there was a question in the test that doesn't support inline feedback, it would disable it for all others as well.
I have inserted the params into the functions without the variables manually, and that seems to solve the issue.
Best regards,
@bidzanaaron