Skip to content

monty(staging): Move authentication boundary to the collection level. - #279

Merged
thenav56 merged 2 commits into
developfrom
feature/montandon-public-catalog
Nov 17, 2026
Merged

thenav56 merged 2 commits into
developfrom
feature/montandon-public-catalog

Conversation

@pantierra

Copy link
Copy Markdown
Collaborator

Addresses part of: IFRCGo/monty-eoapi#8

@thenav56

Copy link
Copy Markdown
Member

@pantierra Thanks. Can you check if this also opens mutation (PUT/POST/PATCH) to public for collections?

@pantierra

Copy link
Copy Markdown
Collaborator Author

No. Writes still need a token. The proxy keeps an explicit list of write routes that require one (POST/PUT/PATCH/DELETE on collections, items and bulk_items), and DEFAULT_PUBLIC=true only opens what isn't on that list.

I did find a related problem. Any valid GO token could write, because the proxy checks writes against the same filters as reads, and every collection currently counts as public. The PR now fixes this: writes need a superuser token, and other tokens get a 403.

@thenav56 thenav56 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thenav56
thenav56 merged commit c1265cb into develop Nov 17, 2026
3 checks passed
@thenav56
thenav56 deleted the feature/montandon-public-catalog branch November 17, 2026 09:48
@thenav56

Copy link
Copy Markdown
Member

Deployed: Argocd Green

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants