Repository navigation
monty(staging): Move authentication boundary to the collection level. - #279
Merged
Merged
Conversation
Member
|
@pantierra Thanks. Can you check if this also opens mutation (PUT/POST/PATCH) to public for collections? |
Collaborator
Author
|
No. Writes still need a token. The proxy keeps an explicit list of write routes that require one (POST/PUT/PATCH/DELETE on collections, items and bulk_items), and I did find a related problem. Any valid GO token could write, because the proxy checks writes against the same filters as reads, and every collection currently counts as public. The PR now fixes this: writes need a superuser token, and other tokens get a 403. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Addresses part of: IFRCGo/monty-eoapi#8