Skip to content

Variability: Provide extension point for enriching configuration names#1659

Merged
kbirken merged 4 commits intomaintenance/mps20241from
feature/embellish_config_names_via_extension_1598
Feb 27, 2026
Merged

Variability: Provide extension point for enriching configuration names#1659
kbirken merged 4 commits intomaintenance/mps20241from
feature/embellish_config_names_via_extension_1598

Conversation

@kbirken
Copy link
Copy Markdown
Member

@kbirken kbirken commented Feb 25, 2026

This PR introduces an extension point for application-specific enriching of configuration names. The default extension for this ensures that nothing is changed at all. The interface IEnrichedConfigNameLogic specifies the API for the extension.

A dozen of test cases has been implemented. They use an extension SomeEnrichedNameLogic which can be activated by the tests by lifting its priority.

In order to test the functionality manually in the IDE, just temporarily increase SomeEnrichedNameLogic .myPriority to a value above zero. Then the test extension will be activated in the IDE. Then the enriched names will be shown for the configuration examples in the tests, e.g.:

image

Or for references (see rack1):

image

The CHANGELOG has been updated.

This solves #1598.

@kbirken kbirken self-assigned this Feb 25, 2026
@kbirken kbirken requested a review from arimer as a code owner February 25, 2026 13:54
@kbirken kbirken added the variability Variability-related tickets label Feb 25, 2026
@kbirken kbirken force-pushed the feature/embellish_config_names_via_extension_1598 branch from e49394a to 29f3940 Compare February 25, 2026 14:04
@kbirken kbirken removed the request for review from mfsoliveira February 25, 2026 14:16
…_config_names_via_extension_1598

# Conflicts:
#	code/languages/org.iets3.opensource/solutions/org.iets3.opensource.build/models/org/iets3/opensource/build/build.mps
@dbinkele
Copy link
Copy Markdown
Member

@kbirken der Kommentar, sagt wenn ‘false’ dann enriched, der Methodenname sagt aber das Gegenteil (oder?)

image

@dbinkele
Copy link
Copy Markdown
Member

@dbinkele
Copy link
Copy Markdown
Member

@kbirken some stale commented code needs removal http://127.0.0.1:63320/node?ref=r%3A01d36390-adf4-48cb-a3e7-d99f41d89a60%28test.org.iets3.variability.configuration.base.enrichedNames%40tests%29%2F7493231619832131126

Details:
- Sort extensions descending and use "first".
- Re-activate code in test which had been commented out.
- Fix wrong javadoc comment in API.
@kbirken kbirken force-pushed the feature/embellish_config_names_via_extension_1598 branch from 936f1e7 to 0b7212f Compare February 27, 2026 14:55
@kbirken kbirken enabled auto-merge February 27, 2026 14:56
@kbirken kbirken merged commit 0188e58 into maintenance/mps20241 Feb 27, 2026
2 checks passed
@kbirken kbirken deleted the feature/embellish_config_names_via_extension_1598 branch February 27, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MPS 2024.1 variability Variability-related tickets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants