Airfoil field output#238
Open
fgvangessel-umd wants to merge 13 commits into
Open
Conversation
Extends simulate() with a field_output flag that additionally returns surface pressure and velocity fields (shape 6×N) from the post-simulation slice file alongside the aerodynamic performance array. - utils.py: add reorder_coords_fields(), mirroring reorder_coords() but carrying VelocityX/Y/Z and CoefPressure through the reordering pipeline - v0.py: extend simulator_output_to_design() and simulate() with field_output=False parameter; simulate returns tuple[NDArray, NDArray] when field_output=True - simulation_jobs.py: propagate field_output through simulate_slurm(), adding surface_fields key to the result dict when requested - dataset_slurm_airfoil.py: add --field_output CLI flag and forward it to each job config Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Brings the command line argument descriptions up to date with all current arguments, including the previously undocumented -account, -type, -minutes_per_sim, -n_slurm_array, and the new --field_output flag. Adds defaults to each entry for clarity. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Looks good to me @fgvangessel-umd. I think you can go ahead and merge. |
…set generation usage
Replace the standalone simulate_field method with an AirfoilSimulationResult subclass of SimulationResult returned from simulate_verbose, carrying the (6, N) surface field array alongside the [drag, lift] objective values. Route simulate_slurm through a verbose flag (simulate_verbose vs simulate) instead of field_output, and rename the dataset generation CLI flag to --verbose. Document the airfoil/slurm workflow in CLAUDE.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
@g-braeunlich can you review my implementation in problems/airfoil/v0.py, specifically the AirfoilSimulationResult derived class and the simulate_verbose implementation. Specifically, that I implemented this in accordance with the approach you had in mind. I've verified that my implementation works with slurm and appropriately returns different data structures based on whether the verbose flag is passed or not. |
g-braeunlich
requested changes
Jun 11, 2026
g-braeunlich
left a comment
g-braeunlich
left a comment
Collaborator
There was a problem hiding this comment.
@fgvangessel-umd Yes, thats exactly how I imagined the use of the new result class.
I have some minor suggestion.
On top of that:
Would not it be more consistent, to also unpack the surface field values into the dict, you are returning in the job result? I.e. position (2d), velocity (3d) and coef_pressure (scalar)?
Slice surface_fields by row (axis 0) to match its (6, N) layout when splitting into coords, velocity, and pressure_coeff; update the docstring Returns section accordingly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
CLAUDE.md was accidentally committed; keep it locally as Claude Code guidance but stop tracking it in the repo. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
g-braeunlich
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Created optional capability to output airfoil fields
Type of change
Please delete options that are not relevant.
Checklist:
pre-commitchecks withpre-commit run --all-filesruff check .andruff formatmypy .Reviewer Checklist: