Use proper ByteBuffer size in ChaCha20Poly1305.updateAAD()#1209
Merged
jasonkatonica merged 2 commits intoIBM:java25from Feb 24, 2026
Merged
Use proper ByteBuffer size in ChaCha20Poly1305.updateAAD()#1209jasonkatonica merged 2 commits intoIBM:java25from
jasonkatonica merged 2 commits intoIBM:java25from
Conversation
When performing an update of the AAD with a ByteBuffer in ChaCha20Poly1305, ensure the size of remaining data is used rather than the capacity of the buffer. Additional tests to verify this behaviour are also added. Signed-off-by: Kostas Tsiounis <kostas.tsiounis@ibm.com>
Signed-off-by: Kostas Tsiounis <kostas.tsiounis@ibm.com>
KostasTsiounis
requested review from
JinhangZhang,
jasonkatonica,
johnpeck-us-ibm and
taoliult
johnpeck-us-ibm
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When performing an update of the
AADwith aByteBufferinChaCha20Poly1305, ensure the size of remaining data is used rather than the capacity of the buffer.Additional tests to verify this behaviour are also added.
Back-ported from: #1196, #1213
Signed-off-by: Kostas Tsiounis kostas.tsiounis@ibm.com