Aul UI d2 5574 identity map v3 technical sample#915
Aul UI d2 5574 identity map v3 technical sample#915aulme wants to merge 10 commits intostaging-phase-2-identity-map-v3from
Conversation
| JOIN uid_mapping um ON (imp.uid = um.current_uid OR imp.uid = um.previous_uid) | ||
| JOIN conversions conv ON (conv.uid = um.current_uid OR conv.uid = um.previous_uid) | ||
| WHERE um.opt_out = FALSE | ||
| ORDER BY RANDOM() |
There was a problem hiding this comment.
why do we want to order by random here?
There was a problem hiding this comment.
Just for the demo - we're showing 10 rows, if we don't order by random you'll just see a bunch of rows for the same impression.
There was a problem hiding this comment.
I think it would help to be more specific that it is 'test data population'
genwhittTTD
left a comment
There was a problem hiding this comment.
I didn't finish. looks great but multiple small copy fixes.
Hoping you could address and I could look again tomorrow -- or even, if you want, I could address... but there are a couple of questions I've marked. Hope this helps anyway. I will look again tomorrow.
There was a problem hiding this comment.
V3 > v3 -- could we do this in the destination please? Or say Version 3
There was a problem hiding this comment.
This isn't the main meaning for "while" so better not to use it, to avoid possible misunderstanding..
From
While the sample is implemented using the Python SDK, the integration patterns are applicable to any SDK or direct API integration.
To
The sample uses the Python SDK, but the integration patterns are applicable to any SDK or direct API integration.
There was a problem hiding this comment.
For the link copy, use the title of the destination doc. In which case we don't need "the" also.
From:
see the [Integration Example README]
To:
see [UID2 Integration Technical Sample]
There was a problem hiding this comment.
-
Is this identical copy? If yes -- on the short term, same edits.
But, better if we implement as a snippet. I can do it if you want. -
A question. Is this applicable to Snowflake, and/or AWS Entity Resolution?
There was a problem hiding this comment.
Yes, it is and it is applicable to Snowflake. Gian is finishing changes to that doc now. This is not applicable to AWS Entity Resolution.
I'll make changes you've suggested above across the board.
Didn't know about snippets, could you please help with that?
| mixed_response = client.generate_identity_map(mixed_input) | ||
| ``` | ||
|
|
||
| ### Integration Example |
There was a problem hiding this comment.
If this is the identical copy, same edits and preferably a snippet... same as prior comment.
There was a problem hiding this comment.
There's a subtle difference for Python SDK vs the others - in other places I say that the pattern is applicable despite the example using Python SDK, here I don't. Not sure it's worth keeping them separate though - happy to make it the same.
There was a problem hiding this comment.
@aulme that makes sense, thx. But I do think we should have a snippet. I think it'd be OK to still have that line in the Python SDK doc... it's kind of unnecessary data but I don't think it sounds weird. It's just info.
LMK if you want me to do that for you in the branch.
There was a problem hiding this comment.
As previous. Don't say DIIs anywhere.
There was a problem hiding this comment.
Is it tokens, not raw UID2s?
There was a problem hiding this comment.
Sorry, I raw UID2s, used colloquially
There was a problem hiding this comment.
V3 > v3
optout handling > opt-out handling
genwhittTTD
left a comment
There was a problem hiding this comment.
@aulme thanks for the fixes. One more small mod on the shared cotent, for a line break.
Some instances of UID that should be UID2, still.
Also instances of DIIs -- I'd really like if we didn't have this, even in the code. It's not correct.
All else looks great, thx.
There was a problem hiding this comment.
Need one extra line break to make a new para. Assuming you want a new para here. Same for all 4 instances.
| mixed_response = client.generate_identity_map(mixed_input) | ||
| ``` | ||
|
|
||
| ### Integration Example |
There was a problem hiding this comment.
@aulme that makes sense, thx. But I do think we should have a snippet. I think it'd be OK to still have that line in the Python SDK doc... it's kind of unnecessary data but I don't think it sounds weird. It's just info.
LMK if you want me to do that for you in the branch.
There was a problem hiding this comment.
UID > UID2
Should be everywhere except code. Since this is for the UID2 site, not shared content.
There was a problem hiding this comment.
Can we get "DIIs" out? Maybe even out of the code? It would be better to say DII. It's a collective term. More than one email address or phone number is still DII.
There are multiple instances. I didn't mark them because they're in the code but if we change them all it will work I think? It would be good to not have this, even in the code.
No description provided.