Add CLAUDE.md and consolidate AI agent conventions#352
Open
Add CLAUDE.md and consolidate AI agent conventions#352
Conversation
aram356
force-pushed
the
feature/claude-md-agent-conventions
branch
from
e1badb5 to
18085c4
Compare
Establish CLAUDE.md as single source of truth for all AI coding agents. Add slash commands, subagents, issue templates, and PR template to standardize workflows.
aram356
force-pushed
the
feature/claude-md-agent-conventions
branch
from
18085c4 to
6c3b5a5
Compare
Add project board add-to-project fallback step and use cleaner GraphQL variable syntax for issue lookup.
Adapted from edgezero PR #190. Performs deep analysis of changed files, classifies findings by severity, and submits formal GitHub reviews with inline comments after user approval.
Audit found 9/14 CLAUDE.md conventions were never used. Removed rules for #[expect], const fn, impl AsRef, Arc::clone, core>alloc>std, similar_asserts, insta, and test_ prefix ban. Aligned wildcard import rule with actual test module usage.
The pr-reviewer agent now checks `gh pr checks` for existing CI results before falling back to local runs, preventing false "Not run" reports when GitHub Actions have already completed.
Adopt the emoji conventions from CONTRIBUTING.md: 🔧 for blockers/high (must change), 🤔 for medium (thinking), ⛏ for low (nitpick), 👍 for positive highlights.
ChristianPavilonis
requested changes
Feb 21, 2026
Collaborator
ChristianPavilonis
left a comment
ChristianPavilonis
left a comment
There was a problem hiding this comment.
Let's include the js and doc format in the flow.
| Before creating the PR, verify the branch is healthy: | ||
|
|
||
| ``` | ||
| cargo fmt --all -- --check |
Collaborator
There was a problem hiding this comment.
should include the javascript format for the js crate and docs
| 1. `cargo fmt --all -- --check` | ||
| 2. `cargo clippy --all-targets --all-features -- -D warnings` | ||
| 3. `cargo test --workspace` | ||
| 4. JS build and test (`cd crates/js/lib && npx vitest run`) |
Collaborator
There was a problem hiding this comment.
add js format for js and docs format
| - [ ] `cargo test --workspace` | ||
| - [ ] `cargo clippy --all-targets --all-features -- -D warnings` | ||
| - [ ] `cargo fmt --all -- --check` | ||
| - [ ] JS tests: `cd crates/js/lib && npx vitest run` |
Collaborator
There was a problem hiding this comment.
add js and docs format
| 3. `cargo fmt --all -- --check` | ||
| 4. `cargo clippy --all-targets --all-features -- -D warnings` | ||
| 5. `cargo test --workspace` | ||
| 6. `cd crates/js/lib && npx vitest run` |
Collaborator
There was a problem hiding this comment.
🔧 docs / js format
| 1. `cargo fmt --all -- --check` | ||
| 2. `cargo clippy --all-targets --all-features -- -D warnings` | ||
| 3. `cargo test --workspace` | ||
| 4. `cd crates/js/lib && npx vitest run` |
Collaborator
There was a problem hiding this comment.
🔧 docs and js format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE.mdas the single source of truth so all AI agents (Claude Code, Codex, Cursor) share identical project conventionsAGENTS.mdas a thin redirect to eliminate duplication and driftChanges
CLAUDE.mdAGENTS.mdCLAUDE.mdwith 8-rule fallback summary for Codex.agents/.mdcrule files andmcp.jsonremoved; content inlined intoCLAUDE.md.claude/settings.json.claude/commands//check-ci,/test-all,/test-crate,/review-changes,/verify.claude/agents/build-validator,code-architect,code-simplifier,verify-app,pr-creator,issue-creator,repo-explorer.github/ISSUE_TEMPLATE/.github/pull_request_template.md.github/dependabot.yml.github/workflows/codeql.yml.gitignore.claude/settings.json,.claude/commands/,.claude/agents/via negation patternREADME.md--no-deps→-- -D warnings)docs/guide/onboarding.mdAGENTS.mdreference to point toCLAUDE.mddocs/guide/testing.mdCloses
Closes #230
Test plan
cargo test --workspacecargo clippy --all-targets --all-features -- -D warningscargo fmt --all -- --checkcd crates/js/lib && npx vitest runChecklist
unwrap()in production code — useexpect("should ...")tracingmacros (notprintln!)