Fix goroutine leaks#5
Open
Wentao0312 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses potential goroutine leaks in the DTE library, specifically in:
ConfigurationHandler.goModelResult.goIn certain execution paths, goroutines may be started but are not guaranteed to exit, which can lead to leaks over time in long-running services.
Problem
During integration and testing, we observed behavior consistent with goroutine leaks originating from these components. Over time, this can:
Expected behavior
All goroutines spawned by the library should terminate cleanly when:
Actual behavior
Some goroutines may remain blocked or alive longer than expected, resulting in resource leakage.
Changes
Notes
This issue was identified during integration in a production-like environment. The changes aim to make goroutine lifecycle management more robust without altering existing functionality.
Happy to iterate further if there are preferred patterns for concurrency management in this project.