Allow for using "Forgot Password" even when a password isn't set#4768
Open
Allow for using "Forgot Password" even when a password isn't set#4768
Conversation
Member
|
@wes-otf Did it not work to block the MS preview stuff with Cloudflare? In the Cloudflare WAF it should be possible to add a rule that block user agents that contain "MicrosoftPreview". |
Member
|
Overrides like this is no fun to handle when updating Django in the future. |
Member
|
If we need to fix this in Hypha I think a solution that adds an extra step to capture MicrosoftPreview is better. Clicking the onetime link would then go to a form with a single "Continue" button. It would force all users to do one extra click but it would also capture MicrosoftPreview and any other similar system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user doesn't have a password set in Hypha and they select "Forgot Password", they will get a prompt notifying them that a password reset email has been sent while Django quietly ignores the sending of the email. This overrides the default
get_usersmethod in Django'sPasswordResetFormto include users without a usable password.As OTF has seen more outlook users have issues with magic links, this would be a nice alternative (even though maybe an annoying extra step) for the time being until we can properly block the link previews.
This PR also includes some very minor UI tweaks I noticed in testing that make reset prompts similar to the rest of Hypha's headers, help texts & buttons.
Test Steps