Repository navigation
Fix highlight region destruction during synchronous layout - #15
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
gtokman
marked this pull request as ready for review
October 9, 2026 18:58
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Synchronous UIKit text layout can abort while
LTXTextLayout.updateHighlightRegions()releases a highlight region. Litext's default MainActor isolation gives this otherwise ordinary Swift class an implicit isolated destructor. On affected runtimes, destruction inside a synchronous task-local scope entersswift_task_deinitOnExecutorImpland fails inTaskLocal::StopLookupScopewith an invalid free (swiftlang/swift#85663).Fix
Declare an empty
nonisolated deinitonLTXHighlightRegion. Its properties and methods retain their existing isolation; destruction has no custom actor-bound cleanup and no longer calls the isolated-deinit runtime. Add a synchronous XCTest that clears a region dictionary inside a task-local scope, checks immediate release, and verifies that the surrounding task-local value is restored.Validation
swift_task_deinitOnExecutor.