Expose line selection on DiffFilesViewController - #13
Open
gtokman wants to merge 1 commit into
Open
Conversation
DiffView already ships the selection engine (isLineSelectionEnabled, handlers, clearLineSelection) but the sectioned diff never wired it. Setting lineSelectionHandler / lineSelectionEndedHandler on DiffFilesViewController now enables tap/drag selection over the hunks; callbacks receive the file's display path plus the LineSelectionInfo (nil on clear). A selection spans one hunk cell — the controller enforces cross-cell exclusivity by clearing the previous cell's highlight, which DiffView supports directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiffViewalready ships the line-selection engine (isLineSelectionEnabled, handlers,clearLineSelection) but the sectioned diff never wired it. This exposes it onDiffFilesViewController:LineSelectionInfo, since a sectioned diff spans files.DiffView.clearLineSelection()exists, unlike theMarkdownTextViewcase).Consumed by v0's combined-diff sheet to drive its "Ask v0" selection → composer flow.
Verification
Package builds for iOS simulator;
DiffPatchDocumentTests(13) pass. Selection behavior exercised via the consuming app.🤖 Generated with Claude Code