Skip to content

Potential fixes for 2 code quality findings #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oxGorou merged 2 commits into from
May 5, 2026
Merged

Potential fixes for 2 code quality findings #84

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b1e8c8
Apply suggested fix to UXTU4Linux/Assets/Modules/setup.py from Copilo…
oxGorou May 5, 2026
f80f7f2
Apply suggested fix to UXTU4Linux/Assets/Modules/setup.py from Copilo…
oxGorou May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions UXTU4Linux/Assets/Modules/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def normalize_required(required_value: object) -> dict[str, tuple[str, ...]]:
for section, keys in required_value.items():
if not isinstance(section, str):
print(" Warning: ignoring invalid cfg.REQUIRED section name (must be str).")
return {}
continue
if keys is None:
normalized[section] = ()
continue
Expand All @@ -148,13 +148,13 @@ def normalize_required(required_value: object) -> dict[str, tuple[str, ...]]:
print(
f" Warning: ignoring invalid cfg.REQUIRED keys for section '{section}' (must be str)."
)
return {}
continue
normalized[section] = tuple(keys)
continue
print(
f" Warning: ignoring invalid cfg.REQUIRED keys container for section '{section}'."
)
return {}
continue
return normalized

if isinstance(required_value, (list, tuple, set)):
Expand All @@ -176,7 +176,7 @@ def has_all_sections() -> bool:
def has_all_keys() -> bool:
for section, keys in required.items():
if not cfg.instance().has_section(section):
continue
return False
section_data = cfg.instance()[section]
if any(key not in section_data for key in keys):
return False
Expand Down
Loading