Merged
Conversation
May not be very close to optimal
The biggest change is the balanced covers should start out tighter than before. Also includes code simplifications and possible performance improvements.
- Replace max-based cover initialization with log-geometric-mean initialization, giving diagonal-scaling covariance up to gauge - Add tests for the new API (symcover, cover, lobjective, qobjective, dotabs, divmag, *_qmin variants, quality vs optimal on testmatrices) - Drop tests for removed functions (symscale, matrixscale, condscale) - Add Statistics to test dependencies - Rewrite README to summarize key highlights and link to docs - Rewrite docs/src/index.md with motivation, examples, algorithm table, and divmag description Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
===========================================
- Coverage 100.00% 98.91% -1.09%
===========================================
Files 2 3 +1
Lines 90 185 +95
===========================================
+ Hits 90 183 +93
- Misses 0 2 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches from an unconstrained formulation to a constrained one, requiring that
a[i] * b[j] >= abs(A[i, j])for alli, j. This was motivated by the observation that near-zero values could greatly distort the former solution; adding the constraint means the solution is dominated by "largest" entries (in a scale-invariant sense).This also:
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com