Package maintenance: Aqua, ExplicitImports, struct mutability, coverage, docstrings, README#43
Conversation
- Remove stale RegisterMismatch from [deps] (only appeared in a warning string) - Add missing compat entries for stdlib and test-only deps - Add Aqua testset with treat_as_own for the intentional RegisterCore.maxshift extension Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
No fields are ever reassigned after construction — only their internal contents are mutated in-place (e.g. ap.λ, ϕ.u). Adding const enforces this invariant and helps the compiler. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…_rotations
Fix _optimize! dispatch for BSpline{Linear{...}} (Interpolations v0.15+ changed
the type from BSpline{Linear} to BSpline{Linear{Throw{OnGrid}}}), so the
subgradient path was silently bypassed. Add new testsets for to_float, p2rigid,
to_full, grid_rotations, fit_sigmoid/sigpenalty, and optimize_rigid. Also declare
RegisterMismatch as an explicit test dependency (it was already used but unlisted).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Module: remove nonexistent qd_rigid, list unexported helpers separately - auto_λ: fix 6-element return signature (was 5, silently misassigned λ_all to datapenalty); two-signature header; Returns: bullet list - auto_λt: fix "fix"→"fit"; document λts/datapenalty return types - fixed_λ: clarify mmis must be "produced by interpolate_mm!" (not "already interpolating"); document ϕ and penalty types - initial_deformation: qualify "globally-optimal" as w.r.t. the quadratic approximation; document converged=false meaning and fallback behavior; add jldoctest example - fit_sigmoid: replace misleading [optional-arg] notation with two explicit signatures; add return description including objective_value; add jldoctest; imperative mood - Add Documenter as test dependency; run doctests via doctest(; manual=false) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Covers: HolyLabRegistry installation, ecosystem table, concepts (mismatch data, regularization, rigid vs deformable), and usage examples for fixed_λ, auto_λ, optimize_rigid, and temporal sequences. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The _optimize! dispatch was widened to BSpline{<:Interpolations.Linear},
which uses the qualified name rather than the imported symbol.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43 +/- ##
===========================================
+ Coverage 36.22% 61.89% +25.67%
===========================================
Files 1 1
Lines 577 580 +3
===========================================
+ Hits 209 359 +150
+ Misses 368 221 -147 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timholy
reviewed
May 20, 2026
| const wfixed::A | ||
| const moving::I | ||
| const SD::SDT | ||
| const thresh |
Member
There was a problem hiding this comment.
If all fields are const you can just delete the mutable instead. Did the agent not suggest this?
Member
There was a problem hiding this comment.
I'll try to change the agent instructions, thanks
Member
There was a problem hiding this comment.
Ok, I've updated the skill. Hopefully it won't happen again.
Do let me know of any weird things like this you see.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
const_optimize!dispatch forBSpline{Linear{...}}(Interpolations v0.15+ broke the linear/subgradient path silently)to_float,p2rigid,to_full,grid_rotations,fit_sigmoid/sigpenalty,optimize_rigidauto_λ6-element return (was 5, silently misassignedλ_alltodatapenalty), fixfit_sigmoidmethod signatures, add return descriptions, addjldoctestexamplesTest plan
🤖 Generated with Claude Code