Open
Conversation
LiveReview Pre-Commit Check: ran (iter:2, coverage:94%)
LiveReview Pre-Commit Check: skipped
LiveReview Pre-Commit Check: ran (iter:1, coverage:0%)
LiveReview Pre-Commit Check: ran (iter:1, coverage:0%)
LiveReview Pre-Commit Check: ran (iter:1, coverage:0%)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Random Name Added in Summary Title
What Is the Issue?
This issue was created based on a PR review trigger.
In the GitHub PR, random names were added to the title.
What Is the RCA?
In the RCA, random names were added in the comment due to the library aliengiraffe/deidentify.
Here is the exact position at which the comment content was changed due to regex issues.
Due to the name regex,
Refactor LED Blinking to State Machineswas changed to
Refactor LED Blinking to Non-Arden ThomasThis function was called like this:
Where the
outvariable is the original content andredactedis the output.What Is the Fix?
As this library didn't have any configuration, it was forked from HexmosTech/deidentify/.
A small configurable function was added.
For example, in the current problem, since the name function is causing issues, I will skip it by explicitly defining
SkipNames: trueindeidentify.TextOptions:configuration added to forked library here is the
Commit Link