fix: honor exclude globs so matched files are omitted from the index - #315
fix: honor exclude globs so matched files are omitted from the index#315lisarium wants to merge 1 commit into
Conversation
|
@Helweg Hi, could you please approve the first-time-contributor workflows and add |
Review finding
Please normalize project-owned absolute paths before glob matching, then add coverage for a project beneath a hidden directory. I verified the regression: the PR fails 5 affected failed-batch cases, while |
Summary
Config
excludeglobs were recorded as skipped but still indexed, becausewalkDirectorycontinued only the inner pattern loop. Matching files (and stale failed-batch retries for those paths) are now omitted from the index.Changes
excludeglob matches incollectFiles/walkDirectory, instead of falling through to include matching./**exclude globs (for example**/common/**)./indexandretryFailedBatches.Testing
How were these changes tested?
npm run build)npm run typecheck)npm run test:run)npm run lint)Release Labels
feature,bug,performance,documentation,dependencies,refactor,test,chore, orskip-changelog)semver:major,semver:minor, orsemver:patch) when neededLabels:
bugRelated Issues
No tracked issue.