Skip to content

refactor: add proper typing to MCP servers controller#225

Open
iVladyuser wants to merge 3 commits into
mainfrom
improve/request-type-safety
Open

refactor: add proper typing to MCP servers controller#225
iVladyuser wants to merge 3 commits into
mainfrom
improve/request-type-safety

Conversation

@iVladyuser
Copy link
Copy Markdown

@iVladyuser iVladyuser commented May 19, 2026

  • Replace any types with AuthRequest interface for Express Request
  • Add McpServer interface for type-safe server object handling
  • Add explicit return type annotations to helper methods
  • Improve IDE autocomplete and type checking for request/server objects

Summary

Changes

Type

  • Bug fix
  • New feature
  • Documentation
  • Refactoring
  • Performance improvement
  • Other (describe below)

Testing

  • Added/updated unit tests
  • Tested manually (describe steps below)
  • No tests needed (explain why)

Checklist

  • My code follows the existing code style
  • I have tested my changes locally
  • I have updated documentation (if applicable)
  • All existing tests pass (npm test)
  • This PR has a descriptive title

Related Issues

- Replace any types with AuthRequest interface for Express Request
- Add McpServer interface for type-safe server object handling
- Add explicit return type annotations to helper methods
- Improve IDE autocomplete and type checking for request/server objects
@iVladyuser iVladyuser requested a review from keysersoft as a code owner May 19, 2026 15:00
@github-actions
Copy link
Copy Markdown

👋 Welcome, @iVladyuser, and thanks for opening your first PR on AnythingMCP!

A few quick pointers:

  • Make sure CI is green before requesting review (Backend, Frontend, Playwright, CodeQL, Trivy).
  • If this is a new adapter, the parametrised catalog.spec.ts test will validate it automatically.
  • Sign off your commits if you can — it's not blocking, just nice to have.

Someone from the core team will look at this within ~48h. If you don't hear back, please ping us in Discussions / Q&A.

⭐ While you wait — if you find AnythingMCP useful, a star helps others discover it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant