Repository navigation
Remove dead weight and scaffold debris - #36
Merged
Merged
Conversation
oil.jpg was a 7200x4800 photo (3.4 MB), shown only as a darkened full-page background by open.css. Resized to 1920x1280 at JPEG quality 78: 202 KB. The original stays in history. [Ticket: #22] Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
org.postgresql:postgresql was declared twice with the same scope, which made Maven warn that the build model is malformed. [Ticket: #21] Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Replace the Spring Initializr description, drop the empty url, licenses, developers and scm blocks, and remove the commented-out jakarta.validation dependency that spring-boot-starter-validation replaced. [Ticket: #21] Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The application is configured for SQL Server, and the PostgreSQL datasource URL in application.properties has been commented out since it was added. [Ticket: #21] Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Removes code that a later version replaced, and that sat beside the live version: - WebSecurityConfig: a UserDetailsService field and constructor; UserDetailsServiceImp is picked up as a bean on its own - TimeClockController: a SimpleDateFormat left from the date migration - VendorServiceImp: an abandoned update guard - WorkOrderJobServiceImp: three loops, replaced by the one-line note that already explained why update() skips those collections - StatementItem: an unfinished finance-charge sketch containing invalid pseudo-code, replaced by a TODO that states the intended rule - Templates: 47 lines of commented-out markup, including a second "Cool Button" in repair_order_details Entity fields for the sales side that was never built are left in place; they are the record of the planned model. [Ticket: #22] Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Nothing uses it: the seeder that did now generates fixed sample values instead. javafaker 0.15 is the project's last release, from 2019, and it pulls in an old snakeyaml. [Ticket: #21] Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Two console.log calls left in page scripts, and in PayPeriodServiceImp two commented-out alternatives to the live date arithmetic plus three commented debug lines. [Ticket: #22] Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #21, #22
Removes weight that does not earn its place. No behavior changes; 41 tests pass and the build now
runs with zero Maven warnings.
Dependencies and build
org.postgresql:postgresqldeclaration, which made Maven report the model asmalformed.
URL in
application.propertieshas been commented out since it was added.javafaker: nothing uses it now that the seeder generates fixed sample values. Version 0.15 isthe project's last release, from 2019, and it drags in an old
snakeyaml.url/licenses/developers/scmblocks, and acommented-out
jakarta.validationdependency thatspring-boot-starter-validationreplaced.Assets
oil.jpgwas a 7200x4800 photo at 3.4 MB, shown only as a darkened full-page background. Resizedto 1920x1280 at quality 78: 202 KB, visually identical in place. The original stays in history.
Commented-out and debug code
Deleted where a later version sits right beside it: an unused
UserDetailsServicefield inWebSecurityConfig, aSimpleDateFormatleft from the date migration, an abandoned update guardin
VendorServiceImp, two superseded date helpers and three debug lines inPayPeriodServiceImp,and 47 lines of commented-out markup across six templates. Two
console.logcalls left in pagescripts are gone, as is a second "Cool Button" that was commented out in
repair_order_details.html.Two blocks were trimmed rather than deleted, because they explained something: the loops in
WorkOrderJobServiceImpare now the one-line note that already said whyupdate()skips thosecollections, and the unfinished finance-charge sketch in
StatementItem— which contained invalidpseudo-code — is now a
TODOstating the intended rule.Kept deliberately: the commented-out entity fields for the sales side that was never built
(
LienHolder,CounterTicket,VehicleSale, stock numbers). They are the record of the plannedmodel, and the README says that side was never started.
Left for later
Out of scope here and noted in #22: the two icons hotlinked from svgrepo.com, pinning the Chart.js
version loaded by the HR page, moving
database_init.sqlout ofsrc/main/java, and renaming the/twoand/f9504195502087067routes.🤖 Generated with Claude Code