Skip to content

Remove dead weight and scaffold debris - #36

Merged
HeftyB merged 8 commits into
mainfrom
chore/remove-dead-weight
Sep 21, 2026
Merged

HeftyB merged 8 commits into
mainfrom
chore/remove-dead-weight

Conversation

@HeftyB

@HeftyB HeftyB commented Sep 21, 2026

Copy link
Copy Markdown
Owner

Refs #21, #22

Removes weight that does not earn its place. No behavior changes; 41 tests pass and the build now
runs with zero Maven warnings.

Dependencies and build

  • The duplicate org.postgresql:postgresql declaration, which made Maven report the model as
    malformed.
  • The remaining PostgreSQL driver: the application is configured for SQL Server, and the PostgreSQL
    URL in application.properties has been commented out since it was added.
  • javafaker: nothing uses it now that the seeder generates fixed sample values. Version 0.15 is
    the project's last release, from 2019, and it drags in an old snakeyaml.
  • The Spring Initializr description, the empty url/licenses/developers/scm blocks, and a
    commented-out jakarta.validation dependency that spring-boot-starter-validation replaced.

Assets

oil.jpg was a 7200x4800 photo at 3.4 MB, shown only as a darkened full-page background. Resized
to 1920x1280 at quality 78: 202 KB, visually identical in place. The original stays in history.

Commented-out and debug code

Deleted where a later version sits right beside it: an unused UserDetailsService field in
WebSecurityConfig, a SimpleDateFormat left from the date migration, an abandoned update guard
in VendorServiceImp, two superseded date helpers and three debug lines in PayPeriodServiceImp,
and 47 lines of commented-out markup across six templates. Two console.log calls left in page
scripts are gone, as is a second "Cool Button" that was commented out in
repair_order_details.html.

Two blocks were trimmed rather than deleted, because they explained something: the loops in
WorkOrderJobServiceImp are now the one-line note that already said why update() skips those
collections, and the unfinished finance-charge sketch in StatementItem — which contained invalid
pseudo-code — is now a TODO stating the intended rule.

Kept deliberately: the commented-out entity fields for the sales side that was never built
(LienHolder, CounterTicket, VehicleSale, stock numbers). They are the record of the planned
model, and the README says that side was never started.

Left for later

Out of scope here and noted in #22: the two icons hotlinked from svgrepo.com, pinning the Chart.js
version loaded by the HR page, moving database_init.sql out of src/main/java, and renaming the
/two and /f9504195502087067 routes.

🤖 Generated with Claude Code

HeftyB and others added 8 commits September 20, 2026 20:36
oil.jpg was a 7200x4800 photo (3.4 MB), shown only as a darkened
full-page background by open.css. Resized to 1920x1280 at JPEG
quality 78: 202 KB. The original stays in history.

[Ticket: #22]

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
org.postgresql:postgresql was declared twice with the same scope,
which made Maven warn that the build model is malformed.

[Ticket: #21]

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Replace the Spring Initializr description, drop the empty url,
licenses, developers and scm blocks, and remove the commented-out
jakarta.validation dependency that spring-boot-starter-validation
replaced.

[Ticket: #21]

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The application is configured for SQL Server, and the PostgreSQL
datasource URL in application.properties has been commented out
since it was added.

[Ticket: #21]

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Removes code that a later version replaced, and that sat beside the
live version:

- WebSecurityConfig: a UserDetailsService field and constructor;
  UserDetailsServiceImp is picked up as a bean on its own
- TimeClockController: a SimpleDateFormat left from the date migration
- VendorServiceImp: an abandoned update guard
- WorkOrderJobServiceImp: three loops, replaced by the one-line note
  that already explained why update() skips those collections
- StatementItem: an unfinished finance-charge sketch containing
  invalid pseudo-code, replaced by a TODO that states the intended
  rule
- Templates: 47 lines of commented-out markup, including a second
  "Cool Button" in repair_order_details

Entity fields for the sales side that was never built are left in
place; they are the record of the planned model.

[Ticket: #22]

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Nothing uses it: the seeder that did now generates fixed sample
values instead. javafaker 0.15 is the project's last release, from
2019, and it pulls in an old snakeyaml.

[Ticket: #21]

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Two console.log calls left in page scripts, and in PayPeriodServiceImp
two commented-out alternatives to the live date arithmetic plus three
commented debug lines.

[Ticket: #22]

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@HeftyB HeftyB added this to the Portfolio readiness milestone Sep 21, 2026
@HeftyB HeftyB added the tech-debt Cleanup and refactoring label Sep 21, 2026
@HeftyB HeftyB self-assigned this Sep 21, 2026
@HeftyB
HeftyB merged commit a2a78ee into main Sep 21, 2026
1 check passed
@HeftyB
HeftyB deleted the chore/remove-dead-weight branch September 21, 2026 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tech-debt Cleanup and refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant