Add extra buildings to in-app house purchase forms (RND-1965)#2953
Open
hugokallstrom wants to merge 4 commits into
Open
Add extra buildings to in-app house purchase forms (RND-1965)#2953hugokallstrom wants to merge 4 commits into
hugokallstrom wants to merge 4 commits into
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feature-movingflow'sAddHouseInformationDestination.priceIntentDataUpdatemutation, so returned offers reflect the declared buildings. 14 building types are hardcoded client-side with Lokalise TODO stubs (PriceIntentdoesn't exposeextraBuildingTypesV2).ExtraBuildingsSection.ktunderfeature-purchase-house/ui/extrabuildings/; no shared module extraction (deferred until there's a third consumer).Stack
This PR builds on:
feat/in-app-house-purchase)feat/in-app-vacation-home-purchase)Spec / plan
docs/superpowers/specs/2026-05-22-extra-buildings-in-house-purchase-design.mddocs/superpowers/plans/2026-05-22-extra-buildings-in-house-purchase.mdTest plan
:feature-purchase-house:ktlintCheck :feature-purchase-house:compileDebugKotlingreenFollow-ups (not in this PR)
ExtraBuildingsSection.ktwith proper Lokalise keys for the 14 building-type display names (TODO comments mark each one)ui-extra-buildingsmodule once / if a third consumer appears🤖 Generated with Claude Code