Skip to content

Add extra buildings to in-app house purchase forms (RND-1965)#2953

Open
hugokallstrom wants to merge 4 commits into
feat/in-app-house-purchasefrom
feat/extra-buildings-in-house-purchase
Open

Add extra buildings to in-app house purchase forms (RND-1965)#2953
hugokallstrom wants to merge 4 commits into
feat/in-app-house-purchasefrom
feat/extra-buildings-in-house-purchase

Conversation

@hugokallstrom
Copy link
Copy Markdown
Contributor

Summary

  • Adds an extra-buildings collector (garage, shed, sauna, …) to the in-app vacation-home and villa purchase forms, copying the dialog UI from feature-movingflow's AddHouseInformationDestination.
  • Each form submits the collected list in the existing priceIntentDataUpdate mutation, so returned offers reflect the declared buildings. 14 building types are hardcoded client-side with Lokalise TODO stubs (PriceIntent doesn't expose extraBuildingTypesV2).
  • New shared file ExtraBuildingsSection.kt under feature-purchase-house/ui/extrabuildings/; no shared module extraction (deferred until there's a third consumer).

Stack

This PR builds on:

Spec / plan

  • docs/superpowers/specs/2026-05-22-extra-buildings-in-house-purchase-design.md
  • docs/superpowers/plans/2026-05-22-extra-buildings-in-house-purchase.md

Test plan

  • :feature-purchase-house:ktlintCheck :feature-purchase-house:compileDebugKotlin green
  • Emulator verified end-to-end: empty state → tap Add → dialog with all 14 types → select Garage / 25 m² / water on → Save → row appears as "Garage / 25 m² · Water connected" → tap X → row removed
  • Submit a vacation-home form with one extra building and confirm the returned offer price differs from a submission without (sanity-check the serialization reaches the backend)
  • Repeat the above on the villa form

Follow-ups (not in this PR)

  • Replace English literals in ExtraBuildingsSection.kt with proper Lokalise keys for the 14 building-type display names (TODO comments mark each one)
  • Consider extracting the section to a shared ui-extra-buildings module once / if a third consumer appears

🤖 Generated with Claude Code

@hugokallstrom hugokallstrom requested a review from a team as a code owner May 22, 2026 08:35
@notion-workspace
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant